ash/common/system/chromeos/audio/audio_detailed_view.cc - Issue 2480813003: Reduce views::Border creation verbosity by promoting factory functions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/common/system/chromeos/audio/audio_detailed_view.cc

Issue 2480813003: Reduce views::Border creation verbosity by promoting factory functions (Closed)

Patch Set: fix bad merge Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ash/common/system/chromeos/audio/audio_detailed_view.cc

diff --git a/ash/common/system/chromeos/audio/audio_detailed_view.cc b/ash/common/system/chromeos/audio/audio_detailed_view.cc

index 85858b90236403b5f6246bea1603fc90a99769d7..4b362e2d54e35c8e0c2d14f0037d8f47b864daf4 100644

--- a/ash/common/system/chromeos/audio/audio_detailed_view.cc

+++ b/ash/common/system/chromeos/audio/audio_detailed_view.cc

@@ -79,7 +79,7 @@ void AudioDetailedView::AddScrollListInfoItem(const base::string16& text) {

else

left_margin = margin;

- label->SetBorder(views::Border::CreateEmptyBorder(

+ label->SetBorder(views::CreateEmptyBorder(

ash::kTrayPopupPaddingBetweenItems, left_margin,

ash::kTrayPopupPaddingBetweenItems, right_margin));

label->SetHorizontalAlignment(gfx::ALIGN_LEFT);