ui/app_list/views/search_box_view.cc - Issue 2480813003: Reduce views::Border creation verbosity by promoting factory functions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/app_list/views/search_box_view.cc

Issue 2480813003: Reduce views::Border creation verbosity by promoting factory functions (Closed)

Patch Set: fix bad merge Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/app_list/views/search_box_view.cc

diff --git a/ui/app_list/views/search_box_view.cc b/ui/app_list/views/search_box_view.cc

index b42be5a39641d298445575b7f9c2adf5ed0a4b81..d4284b8b441485cee8b94a804798b278517738fb 100644

--- a/ui/app_list/views/search_box_view.cc

+++ b/ui/app_list/views/search_box_view.cc

@@ -143,7 +143,7 @@ SearchBoxView::SearchBoxView(SearchBoxViewDelegate* delegate,

views::BoxLayout::CROSS_AXIS_ALIGNMENT_CENTER);

layout->set_minimum_cross_axis_size(kPreferredHeight);

- search_box_->SetBorder(views::Border::NullBorder());

+ search_box_->SetBorder(views::NullBorder());

search_box_->SetTextColor(kSearchTextColor);

search_box_->SetBackgroundColor(kSearchBoxBackground);

search_box_->set_placeholder_text_color(kHintTextColor);