Reduce views::Border creation verbosity by promoting factory functions

ui/views/controls/scroll_view_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/controls/scroll_view.h"
 
 #include "base/macros.h"
 #include "base/run_loop.h"
 #include "base/test/test_timeouts.h"
 #include "base/threading/thread_task_runner_handle.h"
@@ skipping 264 matching lines @@
   View* contents = InstallContents();
   scroll_view_.Layout();
   EXPECT_EQ("0,0 100x100", contents->parent()->bounds().ToString());
 }
 
 // Verifies the viewport and content is sized to fit the available space for
 // bounded scroll view.
 TEST_F(ScrollViewTest, BoundedViewportSizedToFit) {
   View* contents = InstallContents();
   scroll_view_.ClipHeightTo(100, 200);
-  scroll_view_.SetBorder(Border::CreateSolidBorder(2, 0));
+  scroll_view_.SetBorder(CreateSolidBorder(2, 0));
   scroll_view_.Layout();
   EXPECT_EQ("2,2 96x96", contents->parent()->bounds().ToString());
 
   // Make sure the width of |contents| is set properly not to overflow the
   // viewport.
   EXPECT_EQ(96, contents->width());
 }
 
 // Verifies the scrollbars are added as necessary.
 // If on Mac, test the non-overlay scrollbars.
@@ skipping 30 matching lines @@
   EXPECT_EQ(100 - scroll_view_.GetScrollBarHeight(),
             contents->parent()->height());
   CheckScrollbarVisibility(scroll_view_, VERTICAL, true);
   CheckScrollbarVisibility(scroll_view_, HORIZONTAL, true);
 
   // Add a border, test vertical scrollbar.
   const int kTopPadding = 1;
   const int kLeftPadding = 2;
   const int kBottomPadding = 3;
   const int kRightPadding = 4;
-  scroll_view_.SetBorder(Border::CreateEmptyBorder(
-      kTopPadding, kLeftPadding, kBottomPadding, kRightPadding));
+  scroll_view_.SetBorder(CreateEmptyBorder(kTopPadding, kLeftPadding,
+                                           kBottomPadding, kRightPadding));
   contents->SetBounds(0, 0, 50, 400);
   scroll_view_.Layout();
   EXPECT_EQ(
       100 - scroll_view_.GetScrollBarWidth() - kLeftPadding - kRightPadding,
       contents->parent()->width());
   EXPECT_EQ(100 - kTopPadding - kBottomPadding, contents->parent()->height());
   EXPECT_TRUE(!scroll_view_.horizontal_scroll_bar() ||
               !scroll_view_.horizontal_scroll_bar()->visible());
   ASSERT_TRUE(scroll_view_.vertical_scroll_bar() != NULL);
   EXPECT_TRUE(scroll_view_.vertical_scroll_bar()->visible());
@@ skipping 545 matching lines @@
   // Scroll via ScrollView API. Should be reflected on the impl side.
   offset.set_y(kDefaultHeight * 4);
   scroll_view->contents()->ScrollRectToVisible(offset);
   EXPECT_EQ(gfx::ScrollOffset(0, offset.y()), test_api.CurrentOffset());
 
   EXPECT_TRUE(compositor->GetScrollOffsetForLayer(layer_id, &impl_offset));
   EXPECT_EQ(gfx::ScrollOffset(0, offset.y()), impl_offset);
 }
 
 }  // namespace views