Reduce views::Border creation verbosity by promoting factory functions

ui/views/focus/focus_traversal_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stddef.h>
 
 #include "base/macros.h"
 #include "base/run_loop.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/utf_string_conversions.h"
@@ skipping 292 matching lines @@
   GetContentsView()->set_background(
       Background::CreateSolidBackground(SK_ColorWHITE));
 
   Checkbox* cb = new Checkbox(ASCIIToUTF16("This is a checkbox"));
   GetContentsView()->AddChildView(cb);
   // In this fast paced world, who really has time for non hard-coded layout?
   cb->SetBounds(10, 10, 200, 20);
   cb->set_id(TOP_CHECKBOX_ID);
 
   left_container_ = new PaneView();
-  left_container_->SetBorder(Border::CreateSolidBorder(1, SK_ColorBLACK));
+  left_container_->SetBorder(CreateSolidBorder(1, SK_ColorBLACK));
   left_container_->set_background(
       Background::CreateSolidBackground(240, 240, 240));
   left_container_->set_id(LEFT_CONTAINER_ID);
   GetContentsView()->AddChildView(left_container_);
   left_container_->SetBounds(10, 35, 250, 200);
 
   int label_x = 5;
   int label_width = 50;
   int label_height = 15;
   int text_field_width = 150;
@@ skipping 63 matching lines @@
   cb->set_id(FRUIT_CHECKBOX_ID);
   left_container_->AddChildView(cb);
   y += 20;
 
   Combobox* combobox =  new Combobox(&combobox_model_);
   combobox->SetBounds(label_x + label_width + 5, y, 150, 30);
   combobox->set_id(COMBOBOX_ID);
   left_container_->AddChildView(combobox);
 
   right_container_ = new PaneView();
-  right_container_->SetBorder(Border::CreateSolidBorder(1, SK_ColorBLACK));
+  right_container_->SetBorder(CreateSolidBorder(1, SK_ColorBLACK));
   right_container_->set_background(
       Background::CreateSolidBackground(240, 240, 240));
   right_container_->set_id(RIGHT_CONTAINER_ID);
   GetContentsView()->AddChildView(right_container_);
   right_container_->SetBounds(270, 35, 300, 200);
 
   y = 10;
   int radio_button_height = 18;
   int gap_between_radio_buttons = 10;
   RadioButton* radio_button = new RadioButton(ASCIIToUTF16("Asparagus"), 1);
@@ skipping 10 matching lines @@
   RadioButton* radio_button_to_check = radio_button;
   y += radio_button_height + gap_between_radio_buttons;
   radio_button = new RadioButton(ASCIIToUTF16("Cauliflower"), 1);
   radio_button->set_id(CAULIFLOWER_BUTTON_ID);
   right_container_->AddChildView(radio_button);
   radio_button->SetBounds(5, y, 70, radio_button_height);
   radio_button->SetGroup(1);
   y += radio_button_height + gap_between_radio_buttons;
 
   View* inner_container = new View();
-  inner_container->SetBorder(Border::CreateSolidBorder(1, SK_ColorBLACK));
+  inner_container->SetBorder(CreateSolidBorder(1, SK_ColorBLACK));
   inner_container->set_background(
       Background::CreateSolidBackground(230, 230, 230));
   inner_container->set_id(INNER_CONTAINER_ID);
   right_container_->AddChildView(inner_container);
   inner_container->SetBounds(100, 10, 150, 180);
 
   ScrollView* scroll_view = new ScrollView();
   scroll_view->set_id(SCROLL_VIEW_ID);
   inner_container->AddChildView(scroll_view);
   scroll_view->SetBounds(1, 1, 148, 178);
@@ skipping 440 matching lines @@
   GetFocusManager()->AdvanceFocus(false);
   EXPECT_FALSE(GetFocusManager()->GetFocusedView());
 
   // Advance backwards from the root node.
   GetFocusManager()->ClearFocus();
   GetFocusManager()->AdvanceFocus(true);
   EXPECT_FALSE(GetFocusManager()->GetFocusedView());
 }
 
 }  // namespace views