Reduce views::Border creation verbosity by promoting factory functions

ash/common/system/audio/volume_view.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/common/system/audio/volume_view.h"
 
 #include "ash/common/ash_constants.h"
 #include "ash/common/material_design/material_design_controller.h"
 #include "ash/common/metrics/user_metrics_action.h"
 #include "ash/common/system/audio/tray_audio.h"
@@ skipping 140 matching lines @@
       device_type_(NULL),
       more_(NULL),
       is_default_view_(is_default_view) {
   SetFocusBehavior(FocusBehavior::NEVER);
   views::BoxLayout* box_layout = new views::BoxLayout(
       views::BoxLayout::kHorizontal, 0, 0, kBoxLayoutPadding);
   box_layout->SetDefaultFlex(0);
   SetLayoutManager(box_layout);
 
   icon_ = new VolumeButton(this, audio_delegate_);
-  icon_->SetBorder(views::Border::CreateEmptyBorder(
-      0, kTrayPopupPaddingHorizontal, 0, kExtraPaddingBetweenIconAndSlider));
+  icon_->SetBorder(views::CreateEmptyBorder(0, kTrayPopupPaddingHorizontal, 0,
+                                            kExtraPaddingBetweenIconAndSlider));
   AddChildView(icon_);
   slider_ = views::Slider::CreateSlider(
       ash::MaterialDesignController::IsSystemTrayMenuMaterial(), this);
 
   if (ash::MaterialDesignController::IsSystemTrayMenuMaterial()) {
-    slider_->SetBorder(views::Border::CreateEmptyBorder(
+    slider_->SetBorder(views::CreateEmptyBorder(
         gfx::Insets(0, kTrayPopupSliderPaddingMD) + slider_->GetInsets()));
   } else {
-    slider_->SetBorder(views::Border::CreateEmptyBorder(
-        0, 0, 0, kTrayPopupPaddingBetweenItems));
+    slider_->SetBorder(
+        views::CreateEmptyBorder(0, 0, 0, kTrayPopupPaddingBetweenItems));
   }
 
   slider_->set_focus_border_color(kFocusBorderColor);
   slider_->SetValue(
       static_cast<float>(audio_delegate_->GetOutputVolumeLevel()) / 100.0f);
   slider_->SetAccessibleName(
       ui::ResourceBundle::GetSharedInstance().GetLocalizedString(
           IDS_ASH_STATUS_TRAY_VOLUME));
   AddChildView(slider_);
   box_layout->SetFlexForView(slider_, 1);
 
   separator_ = new views::Separator(views::Separator::VERTICAL);
   separator_->SetColor(kButtonStrokeColor);
   separator_->SetPreferredSize(kSeparatorSize);
-  separator_->SetBorder(views::Border::CreateEmptyBorder(
+  separator_->SetBorder(views::CreateEmptyBorder(
       kSeparatorVerticalInset, 0, kSeparatorVerticalInset, kBoxLayoutPadding));
 
   more_region_ = new TrayPopupItemContainer(separator_, true);
   more_region_->SetBorder(
-      views::Border::CreateEmptyBorder(0, 0, 0, kTrayPopupPaddingBetweenItems));
+      views::CreateEmptyBorder(0, 0, 0, kTrayPopupPaddingBetweenItems));
   AddChildView(more_region_);
 
   device_type_ = new views::ImageView;
   more_region_->AddChildView(device_type_);
 
   more_ = new views::ImageView;
   more_->EnableCanvasFlippingForRTLUI(true);
 
   if (MaterialDesignController::IsSystemTrayMenuMaterial()) {
     more_->SetImage(
@@ skipping 32 matching lines @@
   // did not change. In that case, setting the value of the slider won't
   // trigger an update. So explicitly trigger an update.
   Update();
   slider_->set_enable_accessibility_events(true);
 }
 
 void VolumeView::UpdateDeviceTypeAndMore() {
   bool show_more = is_default_view_ && TrayAudio::ShowAudioDeviceMenu() &&
                    audio_delegate_->HasAlternativeSources();
   if (!ash::MaterialDesignController::IsSystemTrayMenuMaterial()) {
-    slider_->SetBorder(views::Border::CreateEmptyBorder(
+    slider_->SetBorder(views::CreateEmptyBorder(
         0, 0, 0, show_more ? kTrayPopupPaddingBetweenItems
                            : kSliderRightPaddingToVolumeViewEdge));
   }
   if (!show_more) {
     more_region_->SetVisible(false);
     return;
   }
 
   // Show output device icon if necessary.
   device_type_->SetVisible(false);
@@ skipping 90 matching lines @@
   separator_->SetSize(gfx::Size(kSeparatorSize, bounds().height()));
 }
 
 void VolumeView::GetAccessibleNodeData(ui::AXNodeData* node_data) {
   // Intentionally overrides ActionableView, leaving |state| unset. A slider
   // childview exposes accessibility data.
 }
 
 }  // namespace tray
 }  // namespace ash