Reduce views::Border creation verbosity by promoting factory functions

ash/common/system/chromeos/ime_menu/ime_menu_tray.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/common/system/chromeos/ime_menu/ime_menu_tray.h"
 
 #include "ash/common/accessibility_delegate.h"
 #include "ash/common/ash_constants.h"
 #include "ash/common/material_design/material_design_controller.h"
 #include "ash/common/session/session_state_delegate.h"
@@ skipping 72 matching lines @@
 };
 
 SystemMenuButton* CreateImeMenuButton(views::ButtonListener* listener,
                                       const gfx::VectorIcon& icon,
                                       int accessible_name_id,
                                       int right_border) {
   SystemMenuButton* button =
       new SystemMenuButton(listener, SystemMenuButton::InkDropStyle::SQUARE,
                            icon, accessible_name_id);
   if (!MaterialDesignController::IsShelfMaterial()) {
-    button->SetBorder(views::Border::CreateSolidSidedBorder(
-        0, 0, 0, right_border, kBorderDarkColor));
+    button->SetBorder(
+        views::CreateSolidSidedBorder(0, 0, 0, right_border, kBorderDarkColor));
   }
   return button;
 }
 
 // The view that contains IME menu title in the material design.
 class ImeTitleView : public views::View {
  public:
   ImeTitleView() {
     auto* box_layout = new views::BoxLayout(views::BoxLayout::kHorizontal, 0,
                                             kMenuSeparatorVerticalPadding, 0);
     SetLayoutManager(box_layout);
 
     views::Label* title_label =
         new views::Label(l10n_util::GetStringUTF16(IDS_ASH_STATUS_TRAY_IME));
     const int title_padding =
         kMenuSeparatorVerticalPadding + (kMenuButtonSize - kMenuIconSize) / 2;
-    title_label->SetBorder(
-        views::Border::CreateEmptyBorder(0, title_padding, 0, 0));
+    title_label->SetBorder(views::CreateEmptyBorder(0, title_padding, 0, 0));
     title_label->SetHorizontalAlignment(gfx::ALIGN_LEFT);
     TrayPopupItemStyle style(GetNativeTheme(),
                              TrayPopupItemStyle::FontStyle::TITLE);
     style.SetupLabel(title_label);
     AddChildView(title_label);
     box_layout->SetFlexForView(title_label, 1);
   }
 
   ~ImeTitleView() override {}
 
@@ skipping 16 matching lines @@
                        public ViewClickListener {
  public:
   ImeButtonsView(ImeMenuTray* ime_menu_tray,
                  bool show_emoji_button,
                  bool show_voice_button,
                  bool show_handwriting_button,
                  bool show_settings_button)
       : ime_menu_tray_(ime_menu_tray) {
     DCHECK(ime_menu_tray_);
 
-    SetBorder(
-        views::Border::CreateSolidSidedBorder(1, 0, 0, 0, kBorderDarkColor));
+    SetBorder(views::CreateSolidSidedBorder(1, 0, 0, 0, kBorderDarkColor));
 
     // If there's only one settings button, the bottom should be a label with
     // normal background. Otherwise, show button icons with header background.
     if (show_settings_button && !show_emoji_button &&
         !show_handwriting_button && !show_voice_button) {
       ShowOneSettingButton();
     } else {
       ShowButtons(show_emoji_button, show_handwriting_button, show_voice_button,
                   show_settings_button);
     }
@@ skipping 144 matching lines @@
 
   // In the material design, we will add a title item with a separator on the
   // top of the IME menu.
   if (MaterialDesignController::IsSystemTrayMenuMaterial()) {
     ImeTitleView* title_view = new ImeTitleView();
     bubble_view->AddChildView(title_view);
     views::Separator* separator =
         new views::Separator(views::Separator::HORIZONTAL);
     separator->SetColor(kBorderLightColor);
     separator->SetPreferredSize(kSeparatorWidth);
-    separator->SetBorder(views::Border::CreateEmptyBorder(
-        0, 0, kMenuSeparatorVerticalPadding, 0));
+    separator->SetBorder(
+        views::CreateEmptyBorder(0, 0, kMenuSeparatorVerticalPadding, 0));
     bubble_view->AddChildView(separator);
   }
 
   // Adds IME list to the bubble.
   ime_list_view_ =
       new ImeListView(nullptr, false, ImeListView::SHOW_SINGLE_IME);
 
   uint32_t current_height = ime_list_view_->scroll_content()->height();
   const gfx::Range height_range = GetImeListViewRange();
   if (current_height > height_range.end()) {
@@ skipping 72 matching lines @@
   }
 }
 
 bool ImeMenuTray::ShouldBlockShelfAutoHide() const {
   return should_block_shelf_auto_hide_;
 }
 
 void ImeMenuTray::SetShelfAlignment(ShelfAlignment alignment) {
   TrayBackgroundView::SetShelfAlignment(alignment);
   if (!MaterialDesignController::IsShelfMaterial())
-    tray_container()->SetBorder(views::Border::NullBorder());
+    tray_container()->SetBorder(views::NullBorder());
 }
 
 base::string16 ImeMenuTray::GetAccessibleNameForTray() {
   return l10n_util::GetStringUTF16(IDS_ASH_IME_MENU_ACCESSIBLE_NAME);
 }
 
 void ImeMenuTray::HideBubbleWithView(const views::TrayBubbleView* bubble_view) {
   if (bubble_->bubble_view() == bubble_view)
     HideImeMenuBubble();
 }
@@ skipping 115 matching lines @@
   WmShell::Get()->system_tray_delegate()->GetCurrentIME(&current_ime_);
 
   // Updates the tray label based on the current input method.
   if (current_ime_.third_party)
     label_->SetText(current_ime_.short_name + base::UTF8ToUTF16("*"));
   else
     label_->SetText(current_ime_.short_name);
 }
 
 }  // namespace ash