Reduce views::Border creation verbosity by promoting factory functions

chrome/browser/ui/views/autofill/card_unmask_prompt_views.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/autofill/card_unmask_prompt_views.h"
 
 #include "base/location.h"
 #include "base/single_thread_task_runner.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/threading/thread_task_runner_handle.h"
@@ skipping 185 matching lines @@
   month_input_->SetEnabled(enabled);
   year_input_->SetEnabled(enabled);
 }
 
 void CardUnmaskPromptViews::ShowNewCardLink() {
   if (new_card_link_)
     return;
 
   new_card_link_ = new views::Link(
       l10n_util::GetStringUTF16(IDS_AUTOFILL_CARD_UNMASK_NEW_CARD_LINK));
-  new_card_link_->SetBorder(views::Border::CreateEmptyBorder(0, 7, 0, 0));
+  new_card_link_->SetBorder(views::CreateEmptyBorder(0, 7, 0, 0));
   new_card_link_->SetUnderline(false);
   new_card_link_->set_listener(this);
   input_row_->AddChildView(new_card_link_);
 }
 
 views::View* CardUnmaskPromptViews::GetContentsView() {
   InitIfNecessary();
   return this;
 }
 
 views::View* CardUnmaskPromptViews::CreateFootnoteView() {
   if (!controller_->CanStoreLocally())
     return nullptr;
 
   // Local storage checkbox and (?) tooltip.
   storage_row_ = new FadeOutView();
   views::BoxLayout* storage_row_layout = new views::BoxLayout(
       views::BoxLayout::kHorizontal, kEdgePadding, kEdgePadding, 0);
   storage_row_->SetLayoutManager(storage_row_layout);
   storage_row_->SetBorder(
-      views::Border::CreateSolidSidedBorder(1, 0, 0, 0, kSubtleBorderColor));
+      views::CreateSolidSidedBorder(1, 0, 0, 0, kSubtleBorderColor));
   storage_row_->set_background(
       views::Background::CreateSolidBackground(kLightShadingColor));
 
   storage_checkbox_ = new views::Checkbox(l10n_util::GetStringUTF16(
       IDS_AUTOFILL_CARD_UNMASK_PROMPT_STORAGE_CHECKBOX));
   storage_checkbox_->SetChecked(controller_->GetStoreLocallyStartState());
   storage_row_->AddChildView(storage_checkbox_);
   storage_row_layout->SetFlexForView(storage_checkbox_, 1);
 
   storage_row_->AddChildView(new TooltipIcon(l10n_util::GetStringUTF16(
@@ skipping 145 matching lines @@
       new views::BoxLayout(views::BoxLayout::kVertical, 0, 0, 12));
   AddChildView(main_contents_);
 
   permanent_error_label_ = new views::Label();
   ui::ResourceBundle& rb = ui::ResourceBundle::GetSharedInstance();
   permanent_error_label_->SetFontList(
       rb.GetFontList(ui::ResourceBundle::BoldFont));
   permanent_error_label_->set_background(
       views::Background::CreateSolidBackground(kWarningColor));
   permanent_error_label_->SetBorder(
-      views::Border::CreateEmptyBorder(12, kEdgePadding, 12, kEdgePadding));
+      views::CreateEmptyBorder(12, kEdgePadding, 12, kEdgePadding));
   permanent_error_label_->SetEnabledColor(SK_ColorWHITE);
   permanent_error_label_->SetAutoColorReadabilityEnabled(false);
   permanent_error_label_->SetVisible(false);
   permanent_error_label_->SetMultiLine(true);
   permanent_error_label_->SetHorizontalAlignment(gfx::ALIGN_LEFT);
   main_contents_->AddChildView(permanent_error_label_);
 
   views::View* controls_container = new views::View();
   controls_container->SetLayoutManager(
       new views::BoxLayout(views::BoxLayout::kVertical, kEdgePadding, 0, 0));
   main_contents_->AddChildView(controls_container);
 
   instructions_ = new views::Label(controller_->GetInstructionsMessage());
   instructions_->SetEnabledColor(kGreyTextColor);
   instructions_->SetMultiLine(true);
   instructions_->SetHorizontalAlignment(gfx::ALIGN_LEFT);
-  instructions_->SetBorder(views::Border::CreateEmptyBorder(0, 0, 16, 0));
+  instructions_->SetBorder(views::CreateEmptyBorder(0, 0, 16, 0));
   controls_container->AddChildView(instructions_);
 
   input_row_ = new views::View();
   input_row_->SetLayoutManager(
       new views::BoxLayout(views::BoxLayout::kHorizontal, 0, 0, 5));
   controls_container->AddChildView(input_row_);
 
   month_input_ = new views::Combobox(&month_combobox_model_);
   month_input_->set_listener(this);
   input_row_->AddChildView(month_input_);
@@ skipping 21 matching lines @@
   views::ImageView* cvc_image = new views::ImageView();
   cvc_image->SetImage(rb.GetImageSkiaNamed(controller_->GetCvcImageRid()));
   input_row_->AddChildView(cvc_image);
 
   views::View* temporary_error = new views::View();
   views::BoxLayout* temporary_error_layout =
       new views::BoxLayout(views::BoxLayout::kHorizontal, 0, 0, 4);
   temporary_error->SetLayoutManager(temporary_error_layout);
   temporary_error_layout->set_cross_axis_alignment(
       views::BoxLayout::CROSS_AXIS_ALIGNMENT_START);
-  temporary_error->SetBorder(views::Border::CreateEmptyBorder(8, 0, 0, 0));
+  temporary_error->SetBorder(views::CreateEmptyBorder(8, 0, 0, 0));
   controls_container->AddChildView(temporary_error);
 
   error_icon_ = new views::ImageView();
   error_icon_->SetVisible(false);
   error_icon_->SetImage(
       gfx::CreateVectorIcon(gfx::VectorIconId::WARNING, 16, kWarningColor));
   temporary_error->AddChildView(error_icon_);
 
   // Reserve vertical space for the error label, assuming it's one line.
   error_label_ = new views::Label(base::ASCIIToUTF16(" "));
@@ skipping 58 matching lines @@
   views::View::OnPaint(canvas);
   canvas->Restore();
 }
 
 void CardUnmaskPromptViews::FadeOutView::SetAlpha(uint8_t alpha) {
   alpha_ = alpha;
   SchedulePaint();
 }
 
 }  // namespace autofill