Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1869)

Unified Diff: ash/common/system/chromeos/network/network_list_md.cc

Issue 2480813003: Reduce views::Border creation verbosity by promoting factory functions (Closed)
Patch Set: fix bad merge Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/common/system/chromeos/network/network_list_md.cc
diff --git a/ash/common/system/chromeos/network/network_list_md.cc b/ash/common/system/chromeos/network/network_list_md.cc
index 92c68c9c8eac9c9afb0b12329f90ac38e6ea1208..63085b0bc48a729a33953c2a436b4e41c82e5aa2 100644
--- a/ash/common/system/chromeos/network/network_list_md.cc
+++ b/ash/common/system/chromeos/network/network_list_md.cc
@@ -124,8 +124,8 @@ class NetworkListViewMd::WifiHeaderRowView : public views::View {
set_background(views::Background::CreateSolidBackground(kBackgroundColor));
// TODO(tdanderson): Need to unify this with the generic menu row class.
views::View* container = new views::View;
- container->SetBorder(views::Border::CreateEmptyBorder(
- 0, kWifiRowLeftInset, 0, kWifiRowRightInset));
+ container->SetBorder(
+ views::CreateEmptyBorder(0, kWifiRowLeftInset, 0, kWifiRowRightInset));
views::FillLayout* layout = new views::FillLayout;
SetLayoutManager(layout);
AddChildView(container);
@@ -157,7 +157,7 @@ class NetworkListViewMd::WifiHeaderRowView : public views::View {
theme->GetSystemColor(ui::NativeTheme::kColorId_FocusedBorderColor);
const int horizontal_padding = (kWiFiButtonSize - join_image_.width()) / 2;
const int vertical_padding = (kWiFiButtonSize - join_image_.height()) / 2;
- join_->SetBorder(views::Border::CreateEmptyBorder(
+ join_->SetBorder(views::CreateEmptyBorder(
gfx::Insets(vertical_padding, horizontal_padding)));
join_->SetFocusForPlatform();
join_->SetFocusPainter(views::Painter::CreateSolidFocusPainter(

Powered by Google App Engine
This is Rietveld 408576698