ui/views/bubble/bubble_frame_view.cc - Issue 2480813003: Reduce views::Border creation verbosity by promoting factory functions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/bubble/bubble_frame_view.cc

Issue 2480813003: Reduce views::Border creation verbosity by promoting factory functions (Closed)

Patch Set: fix bad merge Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/views/bubble/bubble_frame_view.cc

diff --git a/ui/views/bubble/bubble_frame_view.cc b/ui/views/bubble/bubble_frame_view.cc

index b61cb89cef19e353cde473813dce31b07f12cd16..59d51175c9f12f8e1e24102b48e9b920970311c4 100644

--- a/ui/views/bubble/bubble_frame_view.cc

+++ b/ui/views/bubble/bubble_frame_view.cc

@@ -401,7 +401,7 @@ void BubbleFrameView::SetFootnoteView(View* view) {

footnote_container_->set_background(

Background::CreateSolidBackground(kFootnoteBackgroundColor));

footnote_container_->SetBorder(

- Border::CreateSolidSidedBorder(1, 0, 0, 0, kFootnoteBorderColor));

+ CreateSolidSidedBorder(1, 0, 0, 0, kFootnoteBorderColor));

footnote_container_->AddChildView(view);

AddChildView(footnote_container_);

}

« no previous file with comments | « ui/views/border_unittest.cc ('k') | ui/views/color_chooser/color_chooser_view.cc » ('j') | no next file with comments »