chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc - Issue 2480813003: Reduce views::Border creation verbosity by promoting factory functions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc

Issue 2480813003: Reduce views::Border creation verbosity by promoting factory functions (Closed)

Patch Set: fix bad merge Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc

diff --git a/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc b/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc

index a7a869c916791afee8edbd84727a692e96ca2f6a..877e73bd1b05f7847e8e792934e641e602b65bb8 100644

--- a/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc

+++ b/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc

@@ -1595,8 +1595,8 @@ void BookmarkBarView::Init() {

UpdateBookmarksSeparatorVisibility();

instructions_ = new BookmarkBarInstructionsView(this);

- instructions_->SetBorder(views::Border::CreateEmptyBorder(

- kButtonPaddingVertical, 0, kButtonPaddingVertical, 0));

+ instructions_->SetBorder(views::CreateEmptyBorder(kButtonPaddingVertical, 0,

+ kButtonPaddingVertical, 0));

AddChildView(instructions_);

set_context_menu_controller(this);