chrome/browser/ui/views/toolbar/toolbar_actions_bar_bubble_views.cc - Issue 2480813003: Reduce views::Border creation verbosity by promoting factory functions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/toolbar/toolbar_actions_bar_bubble_views.cc

Issue 2480813003: Reduce views::Border creation verbosity by promoting factory functions (Closed)

Patch Set: fix bad merge Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/toolbar/app_menu.cc ('k') | chrome/browser/ui/views/website_settings/website_settings_popup_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/toolbar/toolbar_actions_bar_bubble_views.cc

diff --git a/chrome/browser/ui/views/toolbar/toolbar_actions_bar_bubble_views.cc b/chrome/browser/ui/views/toolbar/toolbar_actions_bar_bubble_views.cc

index c20d88ae1e765a52a8017260c1f3e74777719810..b0ef108dd5f6b852efb9e8329605e5ead3d802a5 100644

--- a/chrome/browser/ui/views/toolbar/toolbar_actions_bar_bubble_views.cc

+++ b/chrome/browser/ui/views/toolbar/toolbar_actions_bar_bubble_views.cc

@@ -122,8 +122,7 @@ void ToolbarActionsBarBubbleViews::Init() {

base::string16 item_list = delegate_->GetItemListText();

if (!item_list.empty()) {

item_list_ = new views::Label(item_list);

- item_list_->SetBorder(

- views::Border::CreateEmptyBorder(0, kListPadding, 0, 0));

+ item_list_->SetBorder(views::CreateEmptyBorder(0, kListPadding, 0, 0));

item_list_->SetMultiLine(true);

item_list_->SizeToFit(width);

item_list_->SetHorizontalAlignment(gfx::ALIGN_LEFT);