ui/message_center/views/message_list_view.cc - Issue 2480813003: Reduce views::Border creation verbosity by promoting factory functions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/message_center/views/message_list_view.cc

Issue 2480813003: Reduce views::Border creation verbosity by promoting factory functions (Closed)

Patch Set: fix bad merge Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/message_center/views/message_list_view.cc

diff --git a/ui/message_center/views/message_list_view.cc b/ui/message_center/views/message_list_view.cc

index 4dc04a60b0917175cc6fe0cc5f415a8ad66a4a6a..a5f2a70a2fd939df21fed5c11775b6cd8ecf811f 100644

--- a/ui/message_center/views/message_list_view.cc

+++ b/ui/message_center/views/message_list_view.cc

@@ -46,7 +46,7 @@ MessageListView::MessageListView(MessageCenterView* message_center_view,

gfx::Insets shadow_insets = MessageView::GetShadowInsets();

set_background(

views::Background::CreateSolidBackground(kMessageCenterBackgroundColor));

- SetBorder(views::Border::CreateEmptyBorder(

+ SetBorder(views::CreateEmptyBorder(

top_down ? 0 : kMarginBetweenItems - shadow_insets.top(), /* top */

kMarginBetweenItems - shadow_insets.left(), /* left */

top_down ? kMarginBetweenItems - shadow_insets.bottom() : 0, /* bottom */