Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Side by Side Diff: chrome/browser/ui/views/cookie_info_view.cc

Issue 2480813003: Reduce views::Border creation verbosity by promoting factory functions (Closed)
Patch Set: fix bad merge Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/views/cookie_info_view.h" 5 #include "chrome/browser/ui/views/cookie_info_view.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 8
9 #include "base/i18n/time_formatting.h" 9 #include "base/i18n/time_formatting.h"
10 #include "base/message_loop/message_loop.h" 10 #include "base/message_loop/message_loop.h"
(...skipping 93 matching lines...) Expand 10 before | Expand all | Expand 10 after
104 views::GridLayout* layout, 104 views::GridLayout* layout,
105 views::Label* label, 105 views::Label* label,
106 views::Textfield* textfield) { 106 views::Textfield* textfield) {
107 layout->StartRow(0, layout_id); 107 layout->StartRow(0, layout_id);
108 layout->AddView(label); 108 layout->AddView(label);
109 layout->AddView( 109 layout->AddView(
110 textfield, 2, 1, views::GridLayout::FILL, views::GridLayout::CENTER); 110 textfield, 2, 1, views::GridLayout::FILL, views::GridLayout::CENTER);
111 111
112 // Now that the Textfield is in the view hierarchy, it can be initialized. 112 // Now that the Textfield is in the view hierarchy, it can be initialized.
113 textfield->SetReadOnly(true); 113 textfield->SetReadOnly(true);
114 textfield->SetBorder(views::Border::NullBorder()); 114 textfield->SetBorder(views::NullBorder());
115 // Color these borderless text areas the same as the containing dialog. 115 // Color these borderless text areas the same as the containing dialog.
116 textfield->SetBackgroundColor(GetNativeTheme()->GetSystemColor( 116 textfield->SetBackgroundColor(GetNativeTheme()->GetSystemColor(
117 ui::NativeTheme::kColorId_DialogBackground)); 117 ui::NativeTheme::kColorId_DialogBackground));
118 textfield->SetTextColor(SkColorSetRGB(0x78, 0x78, 0x78)); 118 textfield->SetTextColor(SkColorSetRGB(0x78, 0x78, 0x78));
119 } 119 }
120 120
121 /////////////////////////////////////////////////////////////////////////////// 121 ///////////////////////////////////////////////////////////////////////////////
122 // CookieInfoView, private: 122 // CookieInfoView, private:
123 123
124 void CookieInfoView::Init() { 124 void CookieInfoView::Init() {
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
167 AddLabelRow(three_column_layout_id, layout, domain_label_, 167 AddLabelRow(three_column_layout_id, layout, domain_label_,
168 domain_value_field_); 168 domain_value_field_);
169 AddLabelRow(three_column_layout_id, layout, path_label_, path_value_field_); 169 AddLabelRow(three_column_layout_id, layout, path_label_, path_value_field_);
170 AddLabelRow(three_column_layout_id, layout, send_for_label_, 170 AddLabelRow(three_column_layout_id, layout, send_for_label_,
171 send_for_value_field_); 171 send_for_value_field_);
172 AddLabelRow(three_column_layout_id, layout, created_label_, 172 AddLabelRow(three_column_layout_id, layout, created_label_,
173 created_value_field_); 173 created_value_field_);
174 AddLabelRow(three_column_layout_id, layout, expires_label_, 174 AddLabelRow(three_column_layout_id, layout, expires_label_,
175 expires_value_field_); 175 expires_value_field_);
176 } 176 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698