ui/views/controls/button/toggle_button.cc - Issue 2480813003: Reduce views::Border creation verbosity by promoting factory functions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/controls/button/toggle_button.cc

Issue 2480813003: Reduce views::Border creation verbosity by promoting factory functions (Closed)

Patch Set: fix bad merge Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/views/controls/button/toggle_button.cc

diff --git a/ui/views/controls/button/toggle_button.cc b/ui/views/controls/button/toggle_button.cc

index ca6915d5d2ea8b589522d25a94c0e4f458e1cacd..342c350720e891058f42fc28ec0c05bd72c65b9a 100644

--- a/ui/views/controls/button/toggle_button.cc

+++ b/ui/views/controls/button/toggle_button.cc

@@ -107,7 +107,7 @@ ToggleButton::ToggleButton(ButtonListener* listener)

thumb_view_(new ThumbView()) {

slide_animation_.SetSlideDuration(80 /* ms */);

slide_animation_.SetTweenType(gfx::Tween::LINEAR);

- SetBorder(Border::CreateEmptyBorder(

+ SetBorder(CreateEmptyBorder(

gfx::Insets(kTrackVerticalMargin, kTrackHorizontalMargin)));

AddChildView(thumb_view_);

SetInkDropMode(InkDropMode::ON);