Reduce views::Border creation verbosity by promoting factory functions

ash/common/system/tray/tray_utils.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/common/system/tray/tray_utils.h"
 
 #include "ash/common/ash_constants.h"
 #include "ash/common/material_design/material_design_controller.h"
 #include "ash/common/session/session_state_delegate.h"
 #include "ash/common/shelf/wm_shelf_util.h"
@@ skipping 18 matching lines @@
  public:
   BorderlessLabelButton(views::ButtonListener* listener,
                         const base::string16& text)
       : LabelButton(listener, text) {
     if (MaterialDesignController::IsSystemTrayMenuMaterial()) {
       SetInkDropMode(views::InkDropHostView::InkDropMode::ON);
       set_has_ink_drop_action_on_click(true);
       set_ink_drop_base_color(kTrayPopupInkDropBaseColor);
       set_ink_drop_visible_opacity(kTrayPopupInkDropRippleOpacity);
       const int kHorizontalPadding = 20;
-      SetBorder(
-          views::Border::CreateEmptyBorder(gfx::Insets(0, kHorizontalPadding)));
+      SetBorder(views::CreateEmptyBorder(gfx::Insets(0, kHorizontalPadding)));
       // TODO(tdanderson): Update focus rect for material design. See
       // crbug.com/615892
     } else {
       SetBorder(std::unique_ptr<views::Border>(new TrayPopupLabelButtonBorder));
       SetFocusPainter(views::Painter::CreateSolidFocusPainter(
           kFocusBorderColor, gfx::Insets(1, 1, 2, 2)));
       set_animate_on_state_change(false);
     }
     SetHorizontalAlignment(gfx::ALIGN_CENTER);
     SetFocusForPlatform();
@@ skipping 49 matching lines @@
     label->SetBackgroundColor(SkColorSetARGB(0, 255, 255, 255));
   }
 }
 
 void SetTrayImageItemBorder(views::View* tray_view, ShelfAlignment alignment) {
   if (MaterialDesignController::IsShelfMaterial())
     return;
 
   const int tray_image_item_padding = GetTrayConstant(TRAY_IMAGE_ITEM_PADDING);
   if (IsHorizontalAlignment(alignment)) {
-    tray_view->SetBorder(views::Border::CreateEmptyBorder(
-        0, tray_image_item_padding, 0, tray_image_item_padding));
+    tray_view->SetBorder(views::CreateEmptyBorder(0, tray_image_item_padding, 0,
+                                                  tray_image_item_padding));
   } else {
-    tray_view->SetBorder(views::Border::CreateEmptyBorder(
+    tray_view->SetBorder(views::CreateEmptyBorder(
         tray_image_item_padding,
         kTrayImageItemHorizontalPaddingVerticalAlignment,
         tray_image_item_padding,
         kTrayImageItemHorizontalPaddingVerticalAlignment));
   }
 }
 
 void SetTrayLabelItemBorder(TrayItemView* tray_view, ShelfAlignment alignment) {
   if (MaterialDesignController::IsShelfMaterial())
     return;
 
   if (IsHorizontalAlignment(alignment)) {
-    tray_view->SetBorder(views::Border::CreateEmptyBorder(
+    tray_view->SetBorder(views::CreateEmptyBorder(
         0, kTrayLabelItemHorizontalPaddingBottomAlignment, 0,
         kTrayLabelItemHorizontalPaddingBottomAlignment));
   } else {
     // Center the label for vertical launcher alignment.
     int horizontal_padding =
         std::max(0, (tray_view->GetPreferredSize().width() -
                      tray_view->label()->GetPreferredSize().width()) /
                         2);
-    tray_view->SetBorder(views::Border::CreateEmptyBorder(
+    tray_view->SetBorder(views::CreateEmptyBorder(
         kTrayLabelItemVerticalPaddingVerticalAlignment, horizontal_padding,
         kTrayLabelItemVerticalPaddingVerticalAlignment, horizontal_padding));
   }
 }
 
 void GetAccessibleLabelFromDescendantViews(
     views::View* view,
     std::vector<base::string16>& out_labels) {
   ui::AXNodeData temp_node_data;
   view->GetAccessibleNodeData(&temp_node_data);
@@ skipping 20 matching lines @@
 
 views::Separator* CreateVerticalSeparator() {
   views::Separator* separator =
       new views::Separator(views::Separator::HORIZONTAL);
   separator->SetPreferredSize(kHorizontalSeparatorHeight);
   separator->SetColor(kHorizontalSeparatorColor);
   return separator;
 }
 
 }  // namespace ash