Reduce views::Border creation verbosity by promoting factory functions

ash/common/system/tray/tray_details_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/common/system/tray/tray_details_view.h"
 
 #include "ash/common/material_design/material_design_controller.h"
 #include "ash/common/system/tray/fixed_sized_scroll_view.h"
 #include "ash/common/system/tray/system_tray.h"
 #include "ash/common/system/tray/system_tray_item.h"
@@ skipping 92 matching lines @@
         : view_(header), offset_(header->y()), sticky_(true) {
       DecorateAsSticky(false);
     }
 
     // Sets decorations on a header row to indicate whether it is |sticky|.
     void DecorateAsSticky(bool sticky) {
       if (sticky_ == sticky)
         return;
       sticky_ = sticky;
       if (sticky) {
-        view_->SetBorder(views::Border::CreateSolidSidedBorder(
+        view_->SetBorder(views::CreateSolidSidedBorder(
             0, 0, kHeaderRowSeparatorThickness, 0, kHeaderRowSeparatorColor));
       } else {
-        view_->SetBorder(views::Border::CreateSolidSidedBorder(
+        view_->SetBorder(views::CreateSolidSidedBorder(
             kHeaderRowSeparatorThickness, 0, 0, 0, kHeaderRowSeparatorColor));
       }
     }
 
     const views::View* view() const { return view_; }
     views::View* view() { return view_; }
     int offset() const { return offset_; }
 
    private:
     // A header View that can be decorated as sticky.
@@ skipping 167 matching lines @@
   }
 
   HandleButtonPressed(sender, event);
 }
 
 void TrayDetailsView::CreateTitleRow(int string_id) {
   DCHECK(!title_row_);
   title_row_ = new SpecialPopupRow();
   title_row_->SetTextLabel(string_id, this);
   if (MaterialDesignController::IsSystemTrayMenuMaterial()) {
-    title_row_->SetBorder(views::Border::CreateEmptyBorder(
-        kTitleRowPaddingTop, 0, kTitleRowPaddingBottom, 0));
+    title_row_->SetBorder(views::CreateEmptyBorder(kTitleRowPaddingTop, 0,
+                                                   kTitleRowPaddingBottom, 0));
     AddChildViewAt(title_row_, 0);
     // In material design, we use a customized bottom border which is nomally a
     // simple separator (views::Separator) but can be combined with an
     // overlapping progress bar.
     title_row_separator_ = new views::View;
     title_row_separator_->SetLayoutManager(new TitleRowSeparatorLayout);
     views::Separator* separator =
         new views::Separator(views::Separator::HORIZONTAL);
     separator->SetColor(kTitleRowSeparatorBorderColor);
     separator->SetPreferredSize(kTitleRowSeparatorBorderHeight);
-    separator->SetBorder(views::Border::CreateEmptyBorder(
+    separator->SetBorder(views::CreateEmptyBorder(
         kTitleRowSeparatorHeight - kTitleRowSeparatorBorderHeight, 0, 0, 0));
     title_row_separator_->AddChildView(separator);
     AddChildViewAt(title_row_separator_, 1);
   } else {
     AddChildViewAt(title_row_, child_count());
   }
 
   CreateExtraTitleRowButtons();
 
   if (MaterialDesignController::IsSystemTrayMenuMaterial())
@@ skipping 100 matching lines @@
     if (index < child_count() - 1 && child_at(index + 1) != title_row_)
       scroll_border_->set_visible(true);
     else
       scroll_border_->set_visible(false);
   }
 
   views::View::OnPaintBorder(canvas);
 }
 
 }  // namespace ash