Remove ASSERT_WITH_SECURITY_IMPLICATION.

Remove ASSERT_WITH_SECURITY_IMPLICATION.

Existing usage will be replaced with SECURITY_DCHECK.

This will allow ClusterFuzz to distinguish between security and
non-security ASSERTs/DCHECKs.

This CL is close to a functional no-op. If you're seeing this in
git blame, you will likely want to check an older revision to see
who actually introduced the assertion in question.

R=tkent@chromium.org
BUG=596760
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/0ed6ce9088448d73aa7466bfe706190b5c28b093
Cr-Commit-Position: refs/heads/master@{#428300}

[Martin Barbella, 2016-10-28 04:09:07]

Description was changed from

==========
Remove ASSERT_WITH_SECURITY_IMPLICATION.

This will allow ClusterFuzz to distinguish between security and
non-security ASSERTs/DCHECKs.

This CL is close to a functional no-op. If you're seeing this in
git blame, you will likely want to check an older revision to see
who actually introduced the assertion in question.

R=tkent@chromium.org
BUG=
==========

to

==========
Remove ASSERT_WITH_SECURITY_IMPLICATION.

This will allow ClusterFuzz to distinguish between security and
non-security ASSERTs/DCHECKs.

This CL is close to a functional no-op. If you're seeing this in
git blame, you will likely want to check an older revision to see
who actually introduced the assertion in question.

R=tkent@chromium.org
BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Martin Barbella, 2016-10-28 04:09:08]

Description was changed from

==========
Remove ASSERT_WITH_SECURITY_IMPLICATION.

This will allow ClusterFuzz to distinguish between security and
non-security ASSERTs/DCHECKs.

This CL is close to a functional no-op. If you're seeing this in
git blame, you will likely want to check an older revision to see
who actually introduced the assertion in question.

R=tkent@chromium.org
BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Remove ASSERT_WITH_SECURITY_IMPLICATION.

This will allow ClusterFuzz to distinguish between security and
non-security ASSERTs/DCHECKs.

This CL is close to a functional no-op. If you're seeing this in
git blame, you will likely want to check an older revision to see
who actually introduced the assertion in question.

R=tkent@chromium.org
BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[Martin Barbella, 2016-10-28 04:20:59]

PTAL.

Most of this is just sed + clang-format, but there are some manual changes in
the following files:

Source/wtf/Assertions.h
Tools/Scripts/webkitpy/style/checkers/cpp.py
Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py

[Martin Barbella, 2016-10-28 04:22:20]

Description was changed from

==========
Remove ASSERT_WITH_SECURITY_IMPLICATION.

This will allow ClusterFuzz to distinguish between security and
non-security ASSERTs/DCHECKs.

This CL is close to a functional no-op. If you're seeing this in
git blame, you will likely want to check an older revision to see
who actually introduced the assertion in question.

R=tkent@chromium.org
BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Remove ASSERT_WITH_SECURITY_IMPLICATION.

Existing usage will be replaced with SECURITY_DCHECK.

This will allow ClusterFuzz to distinguish between security and
non-security ASSERTs/DCHECKs.

This CL is close to a functional no-op. If you're seeing this in
git blame, you will likely want to check an older revision to see
who actually introduced the assertion in question.

R=tkent@chromium.org
BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[tkent, 2016-10-28 04:32:26]

lgtm.
Thanks!

[tkent, 2016-10-28 04:33:13]

Description was changed from

==========
Remove ASSERT_WITH_SECURITY_IMPLICATION.

Existing usage will be replaced with SECURITY_DCHECK.

This will allow ClusterFuzz to distinguish between security and
non-security ASSERTs/DCHECKs.

This CL is close to a functional no-op. If you're seeing this in
git blame, you will likely want to check an older revision to see
who actually introduced the assertion in question.

R=tkent@chromium.org
BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Remove ASSERT_WITH_SECURITY_IMPLICATION.

Existing usage will be replaced with SECURITY_DCHECK.

This will allow ClusterFuzz to distinguish between security and
non-security ASSERTs/DCHECKs.

This CL is close to a functional no-op. If you're seeing this in
git blame, you will likely want to check an older revision to see
who actually introduced the assertion in question.

R=tkent@chromium.org
BUG=596760
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[tkent, 2016-10-28 04:33:17]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2016-10-28 04:33:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-28 06:47:55]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-28 06:50:26]

Description was changed from

==========
Remove ASSERT_WITH_SECURITY_IMPLICATION.

Existing usage will be replaced with SECURITY_DCHECK.

This will allow ClusterFuzz to distinguish between security and
non-security ASSERTs/DCHECKs.

This CL is close to a functional no-op. If you're seeing this in
git blame, you will likely want to check an older revision to see
who actually introduced the assertion in question.

R=tkent@chromium.org
BUG=596760
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Remove ASSERT_WITH_SECURITY_IMPLICATION.

Existing usage will be replaced with SECURITY_DCHECK.

This will allow ClusterFuzz to distinguish between security and
non-security ASSERTs/DCHECKs.

This CL is close to a functional no-op. If you're seeing this in
git blame, you will likely want to check an older revision to see
who actually introduced the assertion in question.

R=tkent@chromium.org
BUG=596760
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/0ed6ce9088448d73aa7466bfe706190b5c28b093
Cr-Commit-Position: refs/heads/master@{#428300}
==========

[commit-bot: I haz the power, 2016-10-28 06:50:27]

Patchset 2 (id:??) landed as
https://crrev.com/0ed6ce9088448d73aa7466bfe706190b5c28b093
Cr-Commit-Position: refs/heads/master@{#428300}