third_party/WebKit/Source/core/html/parser/HTMLFormattingElementList.cpp - Issue 2458003002: Remove ASSERT_WITH_SECURITY_IMPLICATION.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/parser/HTMLFormattingElementList.cpp

Issue 2458003002: Remove ASSERT_WITH_SECURITY_IMPLICATION. (Closed)

Patch Set: Minor formatting fix Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.cpp ('k') | third_party/WebKit/Source/core/inspector/InspectorTaskRunner.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/parser/HTMLFormattingElementList.cpp

diff --git a/third_party/WebKit/Source/core/html/parser/HTMLFormattingElementList.cpp b/third_party/WebKit/Source/core/html/parser/HTMLFormattingElementList.cpp

index 6e568daa671f108790326905b21fee9fa2563666..7b5d368487a308e5489ae00e68c51d6d808be876 100644

--- a/third_party/WebKit/Source/core/html/parser/HTMLFormattingElementList.cpp

+++ b/third_party/WebKit/Source/core/html/parser/HTMLFormattingElementList.cpp

@@ -85,7 +85,7 @@ void HTMLFormattingElementList::swapTo(Element* oldElement,

return;

}

size_t index = bookmark.mark() - first();

- ASSERT_WITH_SECURITY_IMPLICATION(index < size());

+ SECURITY_DCHECK(index < size());

m_entries.insert(index + 1, newItem);

remove(oldElement);

}