third_party/WebKit/Source/wtf/text/StringImpl.h - Issue 2458003002: Remove ASSERT_WITH_SECURITY_IMPLICATION.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/wtf/text/StringImpl.h

Issue 2458003002: Remove ASSERT_WITH_SECURITY_IMPLICATION. (Closed)

Patch Set: Minor formatting fix Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/wtf/text/StringImpl.h

diff --git a/third_party/WebKit/Source/wtf/text/StringImpl.h b/third_party/WebKit/Source/wtf/text/StringImpl.h

index 9ad5c6493396536c19dbba00e8417edb591e1e82..2df9c7ea03b19b9f0f04704fdfbef63cfd819aef 100644

--- a/third_party/WebKit/Source/wtf/text/StringImpl.h

+++ b/third_party/WebKit/Source/wtf/text/StringImpl.h

@@ -319,7 +319,7 @@ class WTF_EXPORT StringImpl {

PassRefPtr<StringImpl> substring(unsigned pos, unsigned len = UINT_MAX);

UChar operator[](unsigned i) const {

- ASSERT_WITH_SECURITY_IMPLICATION(i < m_length);

+ SECURITY_DCHECK(i < m_length);

if (is8Bit())

return characters8()[i];

return characters16()[i];