third_party/WebKit/Source/core/layout/LayoutBox.cpp - Issue 2458003002: Remove ASSERT_WITH_SECURITY_IMPLICATION.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBox.cpp

Issue 2458003002: Remove ASSERT_WITH_SECURITY_IMPLICATION. (Closed)

Patch Set: Minor formatting fix Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutBox.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutBox.cpp b/third_party/WebKit/Source/core/layout/LayoutBox.cpp

index a6a949e465af92a7e47b69d289eebb46082deeaa..4dfbc73493cb7e3b7063d8da5aaf32d77d6cbee9 100644

--- a/third_party/WebKit/Source/core/layout/LayoutBox.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutBox.cpp

@@ -3395,7 +3395,7 @@ LayoutUnit LayoutBox::computeReplacedLogicalHeightUsing(

if (cb->isOutOfFlowPositioned() && cb->style()->height().isAuto() &&

!(cb->style()->top().isAuto() || cb->style()->bottom().isAuto())) {

- ASSERT_WITH_SECURITY_IMPLICATION(cb->isLayoutBlock());

+ SECURITY_DCHECK(cb->isLayoutBlock());

LayoutBlock* block = toLayoutBlock(cb);

LogicalExtentComputedValues computedValues;

block->computeLogicalHeight(block->logicalHeight(), LayoutUnit(),