third_party/WebKit/Source/platform/SharedBufferChunkReader.cpp - Issue 2458003002: Remove ASSERT_WITH_SECURITY_IMPLICATION.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/SharedBufferChunkReader.cpp

Issue 2458003002: Remove ASSERT_WITH_SECURITY_IMPLICATION. (Closed)

Patch Set: Minor formatting fix Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/SharedBufferChunkReader.cpp

diff --git a/third_party/WebKit/Source/platform/SharedBufferChunkReader.cpp b/third_party/WebKit/Source/platform/SharedBufferChunkReader.cpp

index 30b835a82755915deba2bb5c0c33a0db2314ff65..b7e36f44e220953625b769a45b9fe8811e87f487 100644

--- a/third_party/WebKit/Source/platform/SharedBufferChunkReader.cpp

+++ b/third_party/WebKit/Source/platform/SharedBufferChunkReader.cpp

@@ -79,8 +79,7 @@ bool SharedBufferChunkReader::nextChunk(Vector<char>& chunk,

char currentCharacter = m_segment[m_segmentIndex++];

if (currentCharacter != m_separator[m_separatorIndex]) {

if (m_separatorIndex > 0) {

- ASSERT_WITH_SECURITY_IMPLICATION(m_separatorIndex <=

- m_separator.size());

+ SECURITY_DCHECK(m_separatorIndex <= m_separator.size());

chunk.append(m_separator.data(), m_separatorIndex);

m_separatorIndex = 0;

}