third_party/WebKit/Source/core/layout/api/LayoutBoxItem.h - Issue 2458003002: Remove ASSERT_WITH_SECURITY_IMPLICATION.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/api/LayoutBoxItem.h

Issue 2458003002: Remove ASSERT_WITH_SECURITY_IMPLICATION. (Closed)

Patch Set: Minor formatting fix Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/api/LayoutBoxItem.h

diff --git a/third_party/WebKit/Source/core/layout/api/LayoutBoxItem.h b/third_party/WebKit/Source/core/layout/api/LayoutBoxItem.h

index 539bfee5c04a85ae0122dae775dfa33f78a3e7dd..a93c022df467f84758665e03a426afa142b2dab7 100644

--- a/third_party/WebKit/Source/core/layout/api/LayoutBoxItem.h

+++ b/third_party/WebKit/Source/core/layout/api/LayoutBoxItem.h

@@ -20,7 +20,7 @@ class LayoutBoxItem : public LayoutBoxModel {

explicit LayoutBoxItem(LayoutBox* layoutBox) : LayoutBoxModel(layoutBox) {}

explicit LayoutBoxItem(const LayoutItem& item) : LayoutBoxModel(item) {

- ASSERT_WITH_SECURITY_IMPLICATION(!item || item.isBox());

+ SECURITY_DCHECK(!item || item.isBox());

}

explicit LayoutBoxItem(std::nullptr_t) : LayoutBoxModel(nullptr) {}