Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(431)

Unified Diff: third_party/WebKit/Source/core/page/WindowFeatures.cpp

Issue 2458003002: Remove ASSERT_WITH_SECURITY_IMPLICATION. (Closed)
Patch Set: Minor formatting fix Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/page/WindowFeatures.cpp
diff --git a/third_party/WebKit/Source/core/page/WindowFeatures.cpp b/third_party/WebKit/Source/core/page/WindowFeatures.cpp
index 52ecf2427a22e9ff4884aee85ef2b6990476dbca..f1d78f9e4595cc69d89b2d6e06006575423c684e 100644
--- a/third_party/WebKit/Source/core/page/WindowFeatures.cpp
+++ b/third_party/WebKit/Source/core/page/WindowFeatures.cpp
@@ -92,7 +92,7 @@ WindowFeatures::WindowFeatures(const String& features)
i++;
keyEnd = i;
- ASSERT_WITH_SECURITY_IMPLICATION(i <= length);
+ SECURITY_DCHECK(i <= length);
// skip to first '=', but don't skip past a ',' or the end of the string
while (i < length && buffer[i] != '=') {
@@ -101,7 +101,7 @@ WindowFeatures::WindowFeatures(const String& features)
i++;
}
- ASSERT_WITH_SECURITY_IMPLICATION(i <= length);
+ SECURITY_DCHECK(i <= length);
// Skip to first non-separator, but don't skip past a ',' or the end of the
// string.
@@ -112,14 +112,14 @@ WindowFeatures::WindowFeatures(const String& features)
}
valueBegin = i;
- ASSERT_WITH_SECURITY_IMPLICATION(i <= length);
+ SECURITY_DCHECK(i <= length);
// skip to first separator
while (i < length && !isWindowFeaturesSeparator(buffer[i]))
i++;
valueEnd = i;
- ASSERT_WITH_SECURITY_IMPLICATION(i <= length);
+ SECURITY_DCHECK(i <= length);
String keyString(buffer.substring(keyBegin, keyEnd - keyBegin));
String valueString(buffer.substring(valueBegin, valueEnd - valueBegin));
« no previous file with comments | « third_party/WebKit/Source/core/layout/svg/SVGResources.cpp ('k') | third_party/WebKit/Source/core/paint/SVGMaskPainter.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698