third_party/WebKit/Source/platform/SharedBuffer.cpp - Issue 2458003002: Remove ASSERT_WITH_SECURITY_IMPLICATION.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/SharedBuffer.cpp

Issue 2458003002: Remove ASSERT_WITH_SECURITY_IMPLICATION. (Closed)

Patch Set: Minor formatting fix Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/SharedBuffer.cpp

diff --git a/third_party/WebKit/Source/platform/SharedBuffer.cpp b/third_party/WebKit/Source/platform/SharedBuffer.cpp

index f898cd14e4ccc48595c031d43af6bcefb8202701..3dc854b59dc7cbb14683f0b1f286cf761b1a31df 100644

--- a/third_party/WebKit/Source/platform/SharedBuffer.cpp

+++ b/third_party/WebKit/Source/platform/SharedBuffer.cpp

@@ -180,7 +180,7 @@ size_t SharedBuffer::getSomeDataInternal(const char*& someData,

return 0;

}

- ASSERT_WITH_SECURITY_IMPLICATION(position < m_size);

+ SECURITY_DCHECK(position < m_size);

size_t consecutiveSize = m_buffer.size();

if (position < consecutiveSize) {

someData = m_buffer.data() + position;