third_party/WebKit/Source/build/scripts/templates/ElementFactory.cpp.tmpl - Issue 2458003002: Remove ASSERT_WITH_SECURITY_IMPLICATION.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/build/scripts/templates/ElementFactory.cpp.tmpl

Issue 2458003002: Remove ASSERT_WITH_SECURITY_IMPLICATION. (Closed)

Patch Set: Minor formatting fix Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.cpp ('k') | third_party/WebKit/Source/core/css/CSSImageGeneratorValue.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/build/scripts/templates/ElementFactory.cpp.tmpl

diff --git a/third_party/WebKit/Source/build/scripts/templates/ElementFactory.cpp.tmpl b/third_party/WebKit/Source/build/scripts/templates/ElementFactory.cpp.tmpl

index 8125b5d559dab4318ec5005fc67c0473167efa72..fa63a8648b65e2c5e2f734619e9b4f5535cb3df4 100644

--- a/third_party/WebKit/Source/build/scripts/templates/ElementFactory.cpp.tmpl

+++ b/third_party/WebKit/Source/build/scripts/templates/ElementFactory.cpp.tmpl

@@ -105,7 +105,7 @@ static void create{{namespace}}FunctionMap()

if (document.registrationContext() && V0CustomElement::isValidName(localName)) {

Element* element = document.registrationContext()->createCustomTagElement(document, QualifiedName(nullAtom, localName, {{namespace_prefix}}NamespaceURI));

- ASSERT_WITH_SECURITY_IMPLICATION(element->is{{namespace}}Element());

+ SECURITY_DCHECK(element->is{{namespace}}Element());

return to{{namespace}}Element(element);

}