Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: third_party/WebKit/Source/wtf/RefCounted.h

Issue 2458003002: Remove ASSERT_WITH_SECURITY_IMPLICATION. (Closed)
Patch Set: Minor formatting fix Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/wtf/RefCounted.h
diff --git a/third_party/WebKit/Source/wtf/RefCounted.h b/third_party/WebKit/Source/wtf/RefCounted.h
index d3342d2eaa373f8f23a876c78da2c80cecf68e4a..8d23ce970af794e29f32cf01bc297ae5bb3f72ae 100644
--- a/third_party/WebKit/Source/wtf/RefCounted.h
+++ b/third_party/WebKit/Source/wtf/RefCounted.h
@@ -46,12 +46,12 @@ class WTF_EXPORT RefCountedBase {
m_verifier.onRef(m_refCount);
ASSERT(!m_adoptionIsRequired);
#endif
- ASSERT_WITH_SECURITY_IMPLICATION(!m_deletionHasBegun);
+ SECURITY_DCHECK(!m_deletionHasBegun);
++m_refCount;
}
bool hasOneRef() const {
- ASSERT_WITH_SECURITY_IMPLICATION(!m_deletionHasBegun);
+ SECURITY_DCHECK(!m_deletionHasBegun);
#if CHECK_REF_COUNTED_LIFECYCLE
m_verifier.checkSafeToUse();
#endif
@@ -80,7 +80,7 @@ class WTF_EXPORT RefCountedBase {
}
~RefCountedBase() {
- ASSERT_WITH_SECURITY_IMPLICATION(m_deletionHasBegun);
+ SECURITY_DCHECK(m_deletionHasBegun);
#if CHECK_REF_COUNTED_LIFECYCLE
ASSERT(!m_adoptionIsRequired);
#endif
@@ -88,7 +88,7 @@ class WTF_EXPORT RefCountedBase {
// Returns whether the pointer should be freed or not.
bool derefBase() const {
- ASSERT_WITH_SECURITY_IMPLICATION(!m_deletionHasBegun);
+ SECURITY_DCHECK(!m_deletionHasBegun);
#if CHECK_REF_COUNTED_LIFECYCLE
m_verifier.onDeref(m_refCount);
ASSERT(!m_adoptionIsRequired);
@@ -129,7 +129,7 @@ class WTF_EXPORT RefCountedBase {
inline void adopted(RefCountedBase* object) {
if (!object)
return;
- ASSERT_WITH_SECURITY_IMPLICATION(!object->m_deletionHasBegun);
+ SECURITY_DCHECK(!object->m_deletionHasBegun);
#if CHECK_REF_COUNTED_LIFECYCLE
object->m_adoptionIsRequired = false;
#endif
« no previous file with comments | « third_party/WebKit/Source/wtf/HashTable.h ('k') | third_party/WebKit/Source/wtf/ThreadRestrictionVerifier.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698