third_party/WebKit/Source/platform/fonts/GlyphBuffer.h - Issue 2458003002: Remove ASSERT_WITH_SECURITY_IMPLICATION.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/fonts/GlyphBuffer.h

Issue 2458003002: Remove ASSERT_WITH_SECURITY_IMPLICATION. (Closed)

Patch Set: Minor formatting fix Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/fonts/GlyphBuffer.h

diff --git a/third_party/WebKit/Source/platform/fonts/GlyphBuffer.h b/third_party/WebKit/Source/platform/fonts/GlyphBuffer.h

index 5054a5f0fc987910591e7adf00b99b31242a804b..524b1b8a4169cd3c103818b24aed20894e8619e1 100644

--- a/third_party/WebKit/Source/platform/fonts/GlyphBuffer.h

+++ b/third_party/WebKit/Source/platform/fonts/GlyphBuffer.h

@@ -133,7 +133,7 @@ class GlyphBuffer {

// shaping, and adjust the initial advance accordingly -> should

// yield correctly positioned RTL glyphs without any post-shape

// munging).

- ASSERT_WITH_SECURITY_IMPLICATION(!m_offsets.isEmpty());

+ SECURITY_DCHECK(!m_offsets.isEmpty());

for (unsigned i = 0; i + 1 < m_offsets.size(); ++i)

m_offsets[i] = totalWidth - m_offsets[i + 1];

m_offsets.last() = totalWidth - afterOffset;