third_party/WebKit/Source/platform/image-decoders/webp/WEBPImageDecoder.cpp - Issue 2458003002: Remove ASSERT_WITH_SECURITY_IMPLICATION.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/image-decoders/webp/WEBPImageDecoder.cpp

Issue 2458003002: Remove ASSERT_WITH_SECURITY_IMPLICATION. (Closed)

Patch Set: Minor formatting fix Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/image-decoders/ico/ICOImageDecoder.cpp ('k') | third_party/WebKit/Source/platform/text/QuotedPrintable.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/image-decoders/webp/WEBPImageDecoder.cpp

diff --git a/third_party/WebKit/Source/platform/image-decoders/webp/WEBPImageDecoder.cpp b/third_party/WebKit/Source/platform/image-decoders/webp/WEBPImageDecoder.cpp

index 361f2eb858a5a2513585f99096a41d64975c1012..ab8255153c8e0bc1346b3fefe3ee5e1755e857bb 100644

--- a/third_party/WebKit/Source/platform/image-decoders/webp/WEBPImageDecoder.cpp

+++ b/third_party/WebKit/Source/platform/image-decoders/webp/WEBPImageDecoder.cpp

@@ -82,7 +82,7 @@ inline void findBlendRangeAtRow(const blink::IntRect& src,

int& width1,

int& left2,

int& width2) {

- ASSERT_WITH_SECURITY_IMPLICATION(canvasY >= src.y() && canvasY < src.maxY());

+ SECURITY_DCHECK(canvasY >= src.y() && canvasY < src.maxY());

left1 = -1;

width1 = 0;

left2 = -1;

@@ -357,8 +357,8 @@ void WEBPImageDecoder::applyPostProcessing(size_t frameIndex) {

return;

const IntRect& frameRect = buffer.originalFrameRect();

- ASSERT_WITH_SECURITY_IMPLICATION(width == frameRect.width());

- ASSERT_WITH_SECURITY_IMPLICATION(decodedHeight <= frameRect.height());

+ SECURITY_DCHECK(width == frameRect.width());

+ SECURITY_DCHECK(decodedHeight <= frameRect.height());

const int left = frameRect.x();

const int top = frameRect.y();