third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzFace.cpp - Issue 2458003002: Remove ASSERT_WITH_SECURITY_IMPLICATION.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzFace.cpp

Issue 2458003002: Remove ASSERT_WITH_SECURITY_IMPLICATION. (Closed)

Patch Set: Minor formatting fix Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzFace.cpp

diff --git a/third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzFace.cpp b/third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzFace.cpp

index 5c1a7e50a31d0ea12bcc70c12ddf7f7203cfeedb..07fb9426561cadd0b876e4fabae00e9702d59222 100644

--- a/third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzFace.cpp

+++ b/third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzFace.cpp

@@ -158,7 +158,7 @@ HarfBuzzFace::HarfBuzzFace(FontPlatformData* platformData, uint64_t uniqueID)

HarfBuzzFace::~HarfBuzzFace() {

HarfBuzzFontCache::iterator result = harfBuzzFontCache()->find(m_uniqueID);

- ASSERT_WITH_SECURITY_IMPLICATION(result != harfBuzzFontCache()->end());

+ SECURITY_DCHECK(result != harfBuzzFontCache()->end());

ASSERT(result.get()->value->refCount() > 1);

result.get()->value->deref();

if (result.get()->value->refCount() == 1)