Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1174)

Unified Diff: third_party/WebKit/Source/wtf/text/TextCodecUTF8.cpp

Issue 2458003002: Remove ASSERT_WITH_SECURITY_IMPLICATION. (Closed)
Patch Set: Minor formatting fix Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/wtf/text/TextCodecUTF8.cpp
diff --git a/third_party/WebKit/Source/wtf/text/TextCodecUTF8.cpp b/third_party/WebKit/Source/wtf/text/TextCodecUTF8.cpp
index 006e1594f4bfdbfb9aa100af739d6b22c5a0342b..5ce1ca3ffaccd59e5d27c2afe028d8c1f7f85760 100644
--- a/third_party/WebKit/Source/wtf/text/TextCodecUTF8.cpp
+++ b/third_party/WebKit/Source/wtf/text/TextCodecUTF8.cpp
@@ -331,8 +331,8 @@ String TextCodecUTF8::decode(const char* bytes,
character = nonCharacter;
} else {
if (count > end - source) {
- ASSERT_WITH_SECURITY_IMPLICATION(
- end - source < static_cast<ptrdiff_t>(sizeof(m_partialSequence)));
+ SECURITY_DCHECK(end - source <
+ static_cast<ptrdiff_t>(sizeof(m_partialSequence)));
ASSERT(!m_partialSequenceSize);
m_partialSequenceSize = end - source;
memcpy(m_partialSequence, source, m_partialSequenceSize);
@@ -412,8 +412,8 @@ upConvertTo16Bit:
character = nonCharacter;
} else {
if (count > end - source) {
- ASSERT_WITH_SECURITY_IMPLICATION(
- end - source < static_cast<ptrdiff_t>(sizeof(m_partialSequence)));
+ SECURITY_DCHECK(end - source <
+ static_cast<ptrdiff_t>(sizeof(m_partialSequence)));
ASSERT(!m_partialSequenceSize);
m_partialSequenceSize = end - source;
memcpy(m_partialSequence, source, m_partialSequenceSize);
« no previous file with comments | « third_party/WebKit/Source/wtf/text/StringImpl.h ('k') | third_party/WebKit/Source/wtf/typed_arrays/TypedArrayBase.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698