third_party/WebKit/Source/core/editing/iterators/SimplifiedBackwardsTextIterator.cpp - Issue 2458003002: Remove ASSERT_WITH_SECURITY_IMPLICATION.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/iterators/SimplifiedBackwardsTextIterator.cpp

Issue 2458003002: Remove ASSERT_WITH_SECURITY_IMPLICATION. (Closed)

Patch Set: Minor formatting fix Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp ('k') | third_party/WebKit/Source/core/editing/iterators/TextIteratorTextState.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/iterators/SimplifiedBackwardsTextIterator.cpp

diff --git a/third_party/WebKit/Source/core/editing/iterators/SimplifiedBackwardsTextIterator.cpp b/third_party/WebKit/Source/core/editing/iterators/SimplifiedBackwardsTextIterator.cpp

index 0baa17de61116ad2af83413eac40fd4b49b9cc4c..74d859ac3678574a711bb1f39f07f3eae90bc67b 100644

--- a/third_party/WebKit/Source/core/editing/iterators/SimplifiedBackwardsTextIterator.cpp

+++ b/third_party/WebKit/Source/core/editing/iterators/SimplifiedBackwardsTextIterator.cpp

@@ -420,7 +420,7 @@ UChar SimplifiedBackwardsTextIteratorAlgorithm<Strategy>::characterAt(

unsigned index) const {

// TODO(xiaochengh): Mostly copied from TextIteratorTextState::characterAt.

// Should try to improve the code quality by reusing the code.

- ASSERT_WITH_SECURITY_IMPLICATION(index < static_cast<unsigned>(length()));

+ SECURITY_DCHECK(index < static_cast<unsigned>(length()));

if (!(index < static_cast<unsigned>(length())))

return 0;

if (m_singleCharacterBuffer) {