Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Unified Diff: third_party/WebKit/Source/core/layout/line/RootInlineBox.cpp

Issue 2458003002: Remove ASSERT_WITH_SECURITY_IMPLICATION. (Closed)
Patch Set: Minor formatting fix Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/line/RootInlineBox.cpp
diff --git a/third_party/WebKit/Source/core/layout/line/RootInlineBox.cpp b/third_party/WebKit/Source/core/layout/line/RootInlineBox.cpp
index 5a1625bd834369cafe32b5607a4076d726c8f8a7..cf52c32d61acb3c5cfbade7d8c9290da60a46619 100644
--- a/third_party/WebKit/Source/core/layout/line/RootInlineBox.cpp
+++ b/third_party/WebKit/Source/core/layout/line/RootInlineBox.cpp
@@ -546,9 +546,9 @@ void RootInlineBox::setLineBreakInfo(LineLayoutItem obj,
// This has security implications because if the LayoutObject does not point
// to at least one line box, then that LayoutInline can be deleted later
// without resetting the lineBreakObj, leading to use-after-free.
- ASSERT_WITH_SECURITY_IMPLICATION(!obj || obj.isText() ||
- !(obj.isLayoutInline() && obj.isBox() &&
- !LineLayoutBox(obj).inlineBoxWrapper()));
+ SECURITY_DCHECK(!obj || obj.isText() ||
+ !(obj.isLayoutInline() && obj.isBox() &&
+ !LineLayoutBox(obj).inlineBoxWrapper()));
m_lineBreakObj = obj;
m_lineBreakPos = breakPos;

Powered by Google App Engine
This is Rietveld 408576698