Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Side by Side Diff: third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp.py

Issue 2458003002: Remove ASSERT_WITH_SECURITY_IMPLICATION. (Closed)
Patch Set: Minor formatting fix Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # -*- coding: utf-8 -*- 1 # -*- coding: utf-8 -*-
2 # 2 #
3 # Copyright (C) 2009, 2010, 2012 Google Inc. All rights reserved. 3 # Copyright (C) 2009, 2010, 2012 Google Inc. All rights reserved.
4 # Copyright (C) 2009 Torch Mobile Inc. 4 # Copyright (C) 2009 Torch Mobile Inc.
5 # Copyright (C) 2009 Apple Inc. All rights reserved. 5 # Copyright (C) 2009 Apple Inc. All rights reserved.
6 # Copyright (C) 2010 Chris Jerdonek (cjerdonek@webkit.org) 6 # Copyright (C) 2010 Chris Jerdonek (cjerdonek@webkit.org)
7 # 7 #
8 # Redistribution and use in source and binary forms, with or without 8 # Redistribution and use in source and binary forms, with or without
9 # modification, are permitted provided that the following conditions are 9 # modification, are permitted provided that the following conditions are
10 # met: 10 # met:
(...skipping 94 matching lines...) Expand 10 before | Expand all | Expand 10 after
105 ('<=', 'GT'), ('<', 'GE')]: 105 ('<=', 'GT'), ('<', 'GE')]:
106 _CHECK_REPLACEMENT['EXPECT_FALSE'][op] = 'EXPECT_%s' % inv_replacement 106 _CHECK_REPLACEMENT['EXPECT_FALSE'][op] = 'EXPECT_%s' % inv_replacement
107 _CHECK_REPLACEMENT['ASSERT_FALSE'][op] = 'ASSERT_%s' % inv_replacement 107 _CHECK_REPLACEMENT['ASSERT_FALSE'][op] = 'ASSERT_%s' % inv_replacement
108 _CHECK_REPLACEMENT['EXPECT_FALSE_M'][op] = 'EXPECT_%s_M' % inv_replacement 108 _CHECK_REPLACEMENT['EXPECT_FALSE_M'][op] = 'EXPECT_%s_M' % inv_replacement
109 _CHECK_REPLACEMENT['ASSERT_FALSE_M'][op] = 'ASSERT_%s_M' % inv_replacement 109 _CHECK_REPLACEMENT['ASSERT_FALSE_M'][op] = 'ASSERT_%s_M' % inv_replacement
110 110
111 _DEPRECATED_MACROS = [ 111 _DEPRECATED_MACROS = [
112 ['ASSERT', 'DCHECK or its variants'], 112 ['ASSERT', 'DCHECK or its variants'],
113 ['ASSERT_UNUSED', 'DCHECK or its variants'], 113 ['ASSERT_UNUSED', 'DCHECK or its variants'],
114 ['ASSERT_NOT_REACHED', 'NOTREACHED'], 114 ['ASSERT_NOT_REACHED', 'NOTREACHED'],
115 ['ASSERT_WITH_SECURITY_IMPLICATION', 'SECURITY_DCHECK'],
116 ['WTF_LOG', 'DVLOG'] 115 ['WTF_LOG', 'DVLOG']
117 ] 116 ]
118 117
119 # These constants define types of headers for use with 118 # These constants define types of headers for use with
120 # _IncludeState.check_next_include_order(). 119 # _IncludeState.check_next_include_order().
121 _PRIMARY_HEADER = 0 120 _PRIMARY_HEADER = 0
122 _OTHER_HEADER = 1 121 _OTHER_HEADER = 1
123 _MOC_HEADER = 2 122 _MOC_HEADER = 2
124 123
125 124
(...skipping 3513 matching lines...) Expand 10 before | Expand all | Expand 10 after
3639 3638
3640 def check(self, lines): 3639 def check(self, lines):
3641 _process_lines(self.file_path, self.file_extension, lines, 3640 _process_lines(self.file_path, self.file_extension, lines,
3642 self.handle_style_error, self.min_confidence) 3641 self.handle_style_error, self.min_confidence)
3643 3642
3644 3643
3645 # FIXME: Remove this function (requires refactoring unit tests). 3644 # FIXME: Remove this function (requires refactoring unit tests).
3646 def process_file_data(filename, file_extension, lines, error, min_confidence, fs =None): 3645 def process_file_data(filename, file_extension, lines, error, min_confidence, fs =None):
3647 checker = CppChecker(filename, file_extension, error, min_confidence, fs) 3646 checker = CppChecker(filename, file_extension, error, min_confidence, fs)
3648 checker.check(lines) 3647 checker.check(lines)
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698