Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2390373003: Change all == to === and != to !== in trace viewer. (Closed)

Created:
4 years, 2 months ago by alexandermont
Modified:
4 years, 2 months ago
CC:
catapult-reviews_chromium.org, tracing-review_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Change all == to === and != to !== in trace viewer. (Note: This just does the chagne; it doesn't enable the automatic test. Automatic test will be enabled after https://codereview.chromium.org/2361623007 lands.) BUG=catapult:#2895 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/f5dda2322c748a1fe256c26d8b89cc11b7a44ce3

Patch Set 1 #

Total comments: 4

Patch Set 2 : more changes from code review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+459 lines, -456 lines) Patch
M common/eslint/.eslintrc View 1 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/base/color.html View 1 chunk +5 lines, -5 lines 0 comments Download
M tracing/tracing/base/event_target.html View 3 chunks +3 lines, -3 lines 0 comments Download
M tracing/tracing/base/extension_registry.html View 1 chunk +2 lines, -2 lines 0 comments Download
M tracing/tracing/base/extension_registry_basic.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/base/extension_registry_type_based.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/base/iteration_helpers.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/base/iteration_helpers_test.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/base/math.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/base/quad.html View 3 chunks +10 lines, -10 lines 0 comments Download
M tracing/tracing/base/range.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/base/range_utils.html View 2 chunks +3 lines, -3 lines 0 comments Download
M tracing/tracing/base/rect.html View 2 chunks +2 lines, -2 lines 0 comments Download
M tracing/tracing/base/running_statistics.html View 3 chunks +5 lines, -5 lines 0 comments Download
M tracing/tracing/base/settings.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/base/sorted_array_utils.html View 7 chunks +8 lines, -8 lines 0 comments Download
M tracing/tracing/base/statistics.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/base/unittest/html_test_results.html View 4 chunks +6 lines, -6 lines 0 comments Download
M tracing/tracing/base/unittest/interactive_test_runner.html View 3 chunks +5 lines, -5 lines 0 comments Download
M tracing/tracing/base/unittest/suite_loader.html View 2 chunks +3 lines, -3 lines 0 comments Download
M tracing/tracing/base/unittest/test_case.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/base/unittest/test_runner.html View 2 chunks +2 lines, -2 lines 0 comments Download
M tracing/tracing/base/unittest/test_suite.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/base/unittest/text_test_results.html View 2 chunks +3 lines, -3 lines 0 comments Download
M tracing/tracing/base/utils.html View 3 chunks +5 lines, -5 lines 0 comments Download
M tracing/tracing/base/xhr.html View 2 chunks +3 lines, -3 lines 0 comments Download
M tracing/tracing/core/test_utils.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/extras/android/android_auditor.html View 10 chunks +13 lines, -13 lines 0 comments Download
M tracing/tracing/extras/chrome/cc/input_latency_async_slice.html View 2 chunks +2 lines, -2 lines 0 comments Download
M tracing/tracing/extras/chrome/cc/layer_impl.html View 1 chunk +2 lines, -2 lines 0 comments Download
M tracing/tracing/extras/chrome/cc/layer_tree_host_impl.html View 1 chunk +2 lines, -2 lines 0 comments Download
M tracing/tracing/extras/chrome/cc/layer_tree_impl.html View 3 chunks +4 lines, -4 lines 0 comments Download
M tracing/tracing/extras/chrome/cc/picture.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/extras/chrome/cc/region.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/extras/chrome/cc/tile.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/extras/chrome/cc/util.html View 2 chunks +4 lines, -4 lines 0 comments Download
M tracing/tracing/extras/chrome/chrome_user_friendly_category_driver.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/extras/chrome/gpu/gpu_async_slice.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/extras/importer/android/event_log_importer.html View 2 chunks +2 lines, -2 lines 0 comments Download
M tracing/tracing/extras/importer/ddms_importer.html View 2 chunks +3 lines, -3 lines 0 comments Download
M tracing/tracing/extras/importer/etw/etw_importer.html View 6 chunks +12 lines, -12 lines 0 comments Download
M tracing/tracing/extras/importer/etw/eventtrace_parser.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/extras/importer/etw/process_parser.html View 2 chunks +2 lines, -2 lines 0 comments Download
M tracing/tracing/extras/importer/etw/thread_parser.html View 4 chunks +6 lines, -6 lines 0 comments Download
M tracing/tracing/extras/importer/gcloud_trace/gcloud_trace_importer.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/extras/importer/gzip_importer.html View 2 chunks +4 lines, -4 lines 0 comments Download
M tracing/tracing/extras/importer/linux_perf/disk_parser.html View 2 chunks +5 lines, -5 lines 0 comments Download
M tracing/tracing/extras/importer/linux_perf/exynos_parser_test.html View 2 chunks +4 lines, -4 lines 0 comments Download
M tracing/tracing/extras/importer/linux_perf/ftrace_importer.html View 1 8 chunks +21 lines, -21 lines 0 comments Download
M tracing/tracing/extras/importer/linux_perf/gesture_parser.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/extras/importer/linux_perf/i915_parser.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/extras/importer/linux_perf/mali_parser.html View 1 chunk +2 lines, -2 lines 0 comments Download
M tracing/tracing/extras/importer/linux_perf/power_parser.html View 3 chunks +4 lines, -4 lines 0 comments Download
M tracing/tracing/extras/importer/linux_perf/sched_parser.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/extras/importer/linux_perf/sync_parser.html View 2 chunks +3 lines, -3 lines 0 comments Download
M tracing/tracing/extras/importer/trace2html_importer.html View 1 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/extras/importer/trace_code_map.html View 2 chunks +2 lines, -2 lines 0 comments Download
M tracing/tracing/extras/importer/trace_event_importer.html View 6 chunks +7 lines, -7 lines 0 comments Download
M tracing/tracing/extras/importer/trace_event_importer_test.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/extras/importer/v8/codemap.html View 2 chunks +4 lines, -4 lines 0 comments Download
M tracing/tracing/extras/importer/v8/log_reader.html View 4 chunks +5 lines, -5 lines 0 comments Download
M tracing/tracing/extras/importer/v8/splaytree.html View 5 chunks +5 lines, -5 lines 0 comments Download
M tracing/tracing/extras/importer/v8/v8_log_importer.html View 2 chunks +7 lines, -7 lines 0 comments Download
M tracing/tracing/extras/system_stats/system_stats_snapshot.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/extras/tquery/filter.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/importer/empty_importer.html View 1 chunk +3 lines, -3 lines 0 comments Download
M tracing/tracing/importer/find_input_expectations.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/metrics/compare_samples_cmdline.html View 1 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/metrics/system_health/power_metric.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/metrics/v8/utils.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/model/async_slice.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/model/counter.html View 1 chunk +2 lines, -2 lines 0 comments Download
M tracing/tracing/model/cpu.html View 2 chunks +2 lines, -2 lines 0 comments Download
M tracing/tracing/model/cpu_test.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/model/event_set.html View 2 chunks +2 lines, -2 lines 0 comments Download
M tracing/tracing/model/helpers/android_app.html View 5 chunks +11 lines, -10 lines 0 comments Download
M tracing/tracing/model/helpers/android_surface_flinger.html View 3 chunks +3 lines, -3 lines 0 comments Download
M tracing/tracing/model/helpers/chrome_browser_helper.html View 1 chunk +3 lines, -3 lines 0 comments Download
M tracing/tracing/model/helpers/chrome_renderer_helper.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/model/location.html View 3 chunks +3 lines, -3 lines 0 comments Download
M tracing/tracing/model/model.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/model/object_collection.html View 5 chunks +6 lines, -6 lines 0 comments Download
M tracing/tracing/model/object_instance.html View 5 chunks +6 lines, -6 lines 0 comments Download
M tracing/tracing/model/process_test.html View 1 chunk +2 lines, -2 lines 0 comments Download
M tracing/tracing/model/slice.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/model/slice_group.html View 7 chunks +8 lines, -8 lines 0 comments Download
M tracing/tracing/model/slice_group_test.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/model/stack_frame.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/model/thread.html View 1 2 chunks +2 lines, -2 lines 0 comments Download
M tracing/tracing/model/thread_test.html View 2 chunks +2 lines, -2 lines 0 comments Download
M tracing/tracing/model/time_to_object_instance_map.html View 5 chunks +8 lines, -7 lines 0 comments Download
M tracing/tracing/mre/job.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/trace2html.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/analysis/alert_sub_view.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/analysis/analysis_view.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/analysis/generic_object_view.html View 5 chunks +7 lines, -7 lines 0 comments Download
M tracing/tracing/ui/analysis/multi_event_summary.html View 1 chunk +2 lines, -2 lines 0 comments Download
M tracing/tracing/ui/analysis/multi_event_summary_table.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/analysis/multi_object_sub_view.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/analysis/single_object_instance_sub_view.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/analysis/single_power_sample_sub_view.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/analysis/stub_analysis_table.html View 1 chunk +2 lines, -2 lines 0 comments Download
M tracing/tracing/ui/base/bar_chart_test.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/base/chart_base.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/base/chart_base_2d.html View 2 chunks +2 lines, -2 lines 0 comments Download
M tracing/tracing/ui/base/column_chart.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/base/column_chart_test.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/base/container_that_decorates_its_children.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/base/dom_helpers.html View 1 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/base/drag_handle.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/base/grouping_table_groupby_picker.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/base/heading.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/base/hotkey_controller.html View 1 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/base/line_chart.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/base/line_chart_test.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/base/list_and_associated_view.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/base/list_view.html View 6 chunks +6 lines, -6 lines 0 comments Download
M tracing/tracing/ui/base/mouse_mode_selector.html View 3 chunks +3 lines, -3 lines 0 comments Download
M tracing/tracing/ui/base/name_bar_chart.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/base/overlay.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/base/pie_chart.html View 2 chunks +2 lines, -2 lines 0 comments Download
M tracing/tracing/ui/base/table.html View 2 chunks +3 lines, -2 lines 0 comments Download
M tracing/tracing/ui/base/table_test.html View 1 chunk +2 lines, -2 lines 0 comments Download
M tracing/tracing/ui/base/timing_tool.html View 2 chunks +2 lines, -2 lines 0 comments Download
M tracing/tracing/ui/base/ui.html View 4 chunks +6 lines, -6 lines 0 comments Download
M tracing/tracing/ui/extras/about_tracing/record_controller.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/extras/about_tracing/record_selection_dialog.html View 3 chunks +3 lines, -3 lines 0 comments Download
M tracing/tracing/ui/extras/about_tracing/xhr_based_tracing_controller_client.html View 1 chunk +3 lines, -3 lines 0 comments Download
M tracing/tracing/ui/extras/chrome/cc/display_item_debugger.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/extras/chrome/cc/layer_picker.html View 5 chunks +6 lines, -6 lines 0 comments Download
M tracing/tracing/ui/extras/chrome/cc/layer_tree_host_impl_view.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/extras/chrome/cc/layer_tree_quad_stack_view.html View 9 chunks +11 lines, -11 lines 0 comments Download
M tracing/tracing/ui/extras/chrome/cc/picture_ops_list_view.html View 1 chunk +3 lines, -3 lines 0 comments Download
M tracing/tracing/ui/extras/chrome/cc/raster_task_selection.html View 3 chunks +3 lines, -3 lines 0 comments Download
M tracing/tracing/ui/extras/chrome/cc/raster_task_selection_test.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/extras/chrome/cc/raster_task_view.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/extras/chrome/cc/raster_task_view_test.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/extras/deep_reports/html_results.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/extras/drive/index.html View 3 chunks +4 lines, -4 lines 0 comments Download
M tracing/tracing/ui/extras/highlighter/vsync_highlighter.html View 3 chunks +3 lines, -3 lines 0 comments Download
M tracing/tracing/ui/extras/side_panel/alerts_side_panel.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/extras/side_panel/input_latency_side_panel.html View 4 chunks +4 lines, -4 lines 0 comments Download
M tracing/tracing/ui/extras/side_panel/time_summary_side_panel.html View 6 chunks +7 lines, -7 lines 0 comments Download
M tracing/tracing/ui/extras/system_stats/system_stats_instance_track.html View 7 chunks +11 lines, -11 lines 0 comments Download
M tracing/tracing/ui/side_panel/side_panel_container.html View 3 chunks +4 lines, -4 lines 0 comments Download
M tracing/tracing/ui/timeline_display_transform.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/timeline_display_transform_animations.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/timeline_interest_range.html View 2 chunks +2 lines, -2 lines 0 comments Download
M tracing/tracing/ui/timeline_track_view.html View 1 chunk +2 lines, -2 lines 0 comments Download
M tracing/tracing/ui/timeline_track_view_test.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/timeline_view.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/timeline_view_test.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/timeline_viewport.html View 4 chunks +4 lines, -4 lines 0 comments Download
M tracing/tracing/ui/tracks/chart_transform.html View 2 chunks +2 lines, -2 lines 0 comments Download
M tracing/tracing/ui/tracks/drawing_container.html View 1 chunk +2 lines, -2 lines 0 comments Download
M tracing/tracing/ui/tracks/model_track.html View 1 chunk +3 lines, -3 lines 0 comments Download
M tracing/tracing/ui/tracks/multi_row_track.html View 2 chunks +3 lines, -3 lines 0 comments Download
M tracing/tracing/ui/tracks/object_instance_track.html View 2 chunks +2 lines, -2 lines 0 comments Download
M tracing/tracing/ui/tracks/process_summary_track.html View 2 chunks +4 lines, -4 lines 0 comments Download
M tracing/tracing/ui/tracks/rect_track.html View 2 chunks +2 lines, -2 lines 0 comments Download
M tracing/tracing/ui/tracks/slice_group_track.html View 2 chunks +2 lines, -2 lines 0 comments Download
M tracing/tracing/ui/tracks/slice_group_track_test.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/tracks/stacked_bars_track.html View 1 chunk +2 lines, -2 lines 0 comments Download
M tracing/tracing/value/histogram.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/value/numeric.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/value/ui/generic_table_view.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (14 generated)
alexandermont
4 years, 2 months ago (2016-10-04 23:49:29 UTC) #2
charliea (OOO until 10-5)
lgtm w/ comments I'd also definitely suggest playing around with trace viewer for a while ...
4 years, 2 months ago (2016-10-05 18:53:43 UTC) #13
alexandermont
4 years, 2 months ago (2016-10-05 23:13:25 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2390373003/20001
4 years, 2 months ago (2016-10-05 23:13:31 UTC) #17
commit-bot: I haz the power
4 years, 2 months ago (2016-10-05 23:41:47 UTC) #19
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698