Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Unified Diff: tracing/tracing/base/unittest/html_test_results.html

Issue 2390373003: Change all == to === and != to !== in trace viewer. (Closed)
Patch Set: more changes from code review Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tracing/tracing/base/statistics.html ('k') | tracing/tracing/base/unittest/interactive_test_runner.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tracing/tracing/base/unittest/html_test_results.html
diff --git a/tracing/tracing/base/unittest/html_test_results.html b/tracing/tracing/base/unittest/html_test_results.html
index 511e2d27b1a9cd8f29da5aed476783c04a78d3c4..d648fff082dd6e46a3ccc89c3620e3bd97a50461 100644
--- a/tracing/tracing/base/unittest/html_test_results.html
+++ b/tracing/tracing/base/unittest/html_test_results.html
@@ -208,7 +208,7 @@ tr.exportTo('tr.b.unittest', function() {
if (this.showHTMLOutput)
display = '';
else
- display = (this.testStatus_ == TestStatus.RUNNING) ? '' : 'none';
+ display = (this.testStatus_ === TestStatus.RUNNING) ? '' : 'none';
for (var i = 0; i < htmlResults.length; i++)
htmlResults[i].style.display = display;
},
@@ -249,10 +249,10 @@ tr.exportTo('tr.b.unittest', function() {
} else if (this.isFlaky) {
colorCls = 'unittest-flaky';
status = 'flaky';
- } else if (this.testStatus_ == TestStatus.PENDING) {
+ } else if (this.testStatus_ === TestStatus.PENDING) {
colorCls = 'unittest-pending';
status = 'pending';
- } else if (this.testStatus_ == TestStatus.RUNNING) {
+ } else if (this.testStatus_ === TestStatus.RUNNING) {
colorCls = 'unittest-running';
status = 'running';
} else { // DONE_RUNNING and no errors
@@ -345,7 +345,7 @@ tr.exportTo('tr.b.unittest', function() {
updateDisplayStateForResult_: function(res) {
var display;
if (this.showPendingAndPassedTests_) {
- if (res.testStatus == TestStatus.RUNNING ||
+ if (res.testStatus === TestStatus.RUNNING ||
res.hadErrors) {
display = '';
} else {
@@ -466,10 +466,10 @@ tr.exportTo('tr.b.unittest', function() {
notifyTestCompletionToDevServer_: function() {
if (this.numTestsThatPassed_ + this.numTestsThatFailed_ +
- this.numFlakyTests_ == 0) {
+ this.numFlakyTests_ === 0) {
return;
}
- var data = this.numTestsThatFailed_ == 0 ? 'ALL_PASSED' : 'HAD_FAILURES';
+ var data = this.numTestsThatFailed_ === 0 ? 'ALL_PASSED' : 'HAD_FAILURES';
data += '\nPassed tests: ' + this.numTestsThatPassed_ +
' Failed tests: ' + this.numTestsThatFailed_ +
' Flaky tests: ' + this.numFlakyTests_;
« no previous file with comments | « tracing/tracing/base/statistics.html ('k') | tracing/tracing/base/unittest/interactive_test_runner.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698