tracing/tracing/ui/extras/about_tracing/xhr_based_tracing_controller_client.html - Issue 2390373003: Change all == to === and != to !== in trace viewer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tracing/tracing/ui/extras/about_tracing/xhr_based_tracing_controller_client.html

Issue 2390373003: Change all == to === and != to !== in trace viewer. (Closed)

Patch Set: more changes from code review Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tracing/tracing/ui/extras/about_tracing/record_selection_dialog.html ('k') | tracing/tracing/ui/extras/chrome/cc/display_item_debugger.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tracing/tracing/ui/extras/about_tracing/xhr_based_tracing_controller_client.html

diff --git a/tracing/tracing/ui/extras/about_tracing/xhr_based_tracing_controller_client.html b/tracing/tracing/ui/extras/about_tracing/xhr_based_tracing_controller_client.html

index d6ca756bb193ae1bd16e02070d06088baa45e15d..a33e614813ed8714b117affdb17b2663e97085d3 100644

--- a/tracing/tracing/ui/extras/about_tracing/xhr_based_tracing_controller_client.html

+++ b/tracing/tracing/ui/extras/about_tracing/xhr_based_tracing_controller_client.html

@@ -20,13 +20,13 @@ tr.exportTo('tr.ui.e.about_tracing', function() {

data = null;

return new Promise(function(resolve, reject) {

var req = new XMLHttpRequest();

- if (method != 'POST' && data !== null)

+ if (method !== 'POST' && data !== null)

throw new Error('Non-POST should have data==null');

req.open(method, path, true);

req.onreadystatechange = function(e) {

- if (req.readyState == 4) {

+ if (req.readyState === 4) {

window.setTimeout(function() {

- if (req.status == 200 && req.responseText != '##ERROR##') {

+ if (req.status === 200 && req.responseText !== '##ERROR##') {

resolve(req.responseText);

} else {

reject(new Error('Error occured at ' + path));