Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Unified Diff: tracing/tracing/base/unittest/interactive_test_runner.html

Issue 2390373003: Change all == to === and != to !== in trace viewer. (Closed)
Patch Set: more changes from code review Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tracing/tracing/base/unittest/interactive_test_runner.html
diff --git a/tracing/tracing/base/unittest/interactive_test_runner.html b/tracing/tracing/base/unittest/interactive_test_runner.html
index c8d583b5ee616210cd1b0d0f7b6a3b1c0c85ea80..87c5127f57d05d0e678d3e2c49544287e5e98c30 100644
--- a/tracing/tracing/base/unittest/interactive_test_runner.html
+++ b/tracing/tracing/base/unittest/interactive_test_runner.html
@@ -420,7 +420,7 @@ tr.exportTo('tr.b.unittest', function() {
var tests = this.allTests_.filter(function(test) {
var i = test.fullyQualifiedName.indexOf(this.testFilterString_);
- if (i == -1)
+ if (i === -1)
return false;
if (this.testTypeToRun_ !== ALL_TEST_TYPES &&
test.testType !== this.testTypeToRun_)
@@ -521,16 +521,16 @@ tr.exportTo('tr.b.unittest', function() {
function stateFromSearchString(string) {
var state = {};
string.split('&').forEach(function(part) {
- if (part == '')
+ if (part === '')
return;
var kv = part.split('=');
var k, v;
- if (kv.length == 1) {
+ if (kv.length === 1) {
k = kv[0];
v = true;
} else {
k = kv[0];
- if (kv[1] == 'false')
+ if (kv[1] === 'false')
v = false;
else
v = kv[1];
@@ -661,7 +661,7 @@ tr.exportTo('tr.b.unittest', function() {
var state = runner.getState();
var stateString = stateToSearchString(runner.getDefaultState(),
state);
- if (window.location.search.substring(1) == stateString)
+ if (window.location.search.substring(1) === stateString)
return;
updateTitle(state);
« no previous file with comments | « tracing/tracing/base/unittest/html_test_results.html ('k') | tracing/tracing/base/unittest/suite_loader.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698