Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(697)

Side by Side Diff: tracing/tracing/ui/analysis/analysis_view.html

Issue 2390373003: Change all == to === and != to !== in trace viewer. (Closed)
Patch Set: more changes from code review Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 <!DOCTYPE html> 1 <!DOCTYPE html>
2 <!-- 2 <!--
3 Copyright (c) 2014 The Chromium Authors. All rights reserved. 3 Copyright (c) 2014 The Chromium Authors. All rights reserved.
4 Use of this source code is governed by a BSD-style license that can be 4 Use of this source code is governed by a BSD-style license that can be
5 found in the LICENSE file. 5 found in the LICENSE file.
6 --> 6 -->
7 7
8 <link rel="import" href="/tracing/base/iteration_helpers.html"> 8 <link rel="import" href="/tracing/base/iteration_helpers.html">
9 <link rel="import" href="/tracing/model/event_set.html"> 9 <link rel="import" href="/tracing/model/event_set.html">
10 <link rel="import" href="/tracing/ui/analysis/alert_sub_view.html"> 10 <link rel="import" href="/tracing/ui/analysis/alert_sub_view.html">
(...skipping 67 matching lines...) Expand 10 before | Expand all | Expand 10 after
78 function getTabStripLabel(numEvents) { 78 function getTabStripLabel(numEvents) {
79 if (numEvents === 0) 79 if (numEvents === 0)
80 return 'Nothing selected. Tap stuff.'; 80 return 'Nothing selected. Tap stuff.';
81 else if (numEvents === 1) 81 else if (numEvents === 1)
82 return '1 item selected.'; 82 return '1 item selected.';
83 return numEvents + ' items selected.'; 83 return numEvents + ' items selected.';
84 } 84 }
85 85
86 function createSubView(subViewTypeInfo, selection) { 86 function createSubView(subViewTypeInfo, selection) {
87 var tagName; 87 var tagName;
88 if (selection.length == 1) 88 if (selection.length === 1)
89 tagName = subViewTypeInfo.singleTagName; 89 tagName = subViewTypeInfo.singleTagName;
90 else 90 else
91 tagName = subViewTypeInfo.multiTagName; 91 tagName = subViewTypeInfo.multiTagName;
92 92
93 if (tagName === undefined) { 93 if (tagName === undefined) {
94 throw new Error('No view registered for ' + 94 throw new Error('No view registered for ' +
95 subViewTypeInfo.eventConstructor.name); 95 subViewTypeInfo.eventConstructor.name);
96 } 96 }
97 var subView = document.createElement(tagName); 97 var subView = document.createElement(tagName);
98 98
(...skipping 94 matching lines...) Expand 10 before | Expand all | Expand 10 after
193 }, 193 },
194 194
195 /** Changes the highlighted related events if possible. */ 195 /** Changes the highlighted related events if possible. */
196 maybeChangeRelatedEvents_: function(events) { 196 maybeChangeRelatedEvents_: function(events) {
197 if (this.brushingStateController) 197 if (this.brushingStateController)
198 this.brushingStateController.changeAnalysisViewRelatedEvents(events); 198 this.brushingStateController.changeAnalysisViewRelatedEvents(events);
199 } 199 }
200 }); 200 });
201 })(); 201 })();
202 </script> 202 </script>
OLDNEW
« no previous file with comments | « tracing/tracing/ui/analysis/alert_sub_view.html ('k') | tracing/tracing/ui/analysis/generic_object_view.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698