tracing/tracing/ui/tracks/object_instance_track.html - Issue 2390373003: Change all == to === and != to !== in trace viewer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tracing/tracing/ui/tracks/object_instance_track.html

Issue 2390373003: Change all == to === and != to !== in trace viewer. (Closed)

Patch Set: more changes from code review Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tracing/tracing/ui/tracks/object_instance_track.html

diff --git a/tracing/tracing/ui/tracks/object_instance_track.html b/tracing/tracing/ui/tracks/object_instance_track.html

index ac57f7b55d7b6d4ab5fb05152ef771feec9c72f6..f6a4fdda61c837b7b6a39fa70d8bcb5ef5ee8893 100644

--- a/tracing/tracing/ui/tracks/object_instance_track.html

+++ b/tracing/tracing/ui/tracks/object_instance_track.html

@@ -61,7 +61,7 @@ tr.exportTo('tr.ui.tracks', function() {

set objectInstances(objectInstances) {

- if (!objectInstances || objectInstances.length == 0) {

+ if (!objectInstances || objectInstances.length === 0) {

this.heading = '';

this.objectInstances_ = [];

this.objectSnapshots_ = [];

@@ -133,7 +133,7 @@ tr.exportTo('tr.ui.tracks', function() {

if (x > viewRWorld)

break;

- var right = instance.deletionTs == Number.MAX_VALUE ?

+ var right = instance.deletionTs === Number.MAX_VALUE ?

viewRWorld : instance.deletionTs;

ctx.fillStyle = EventPresenter.getObjectInstanceColor(instance);

ctx.fillRect(x, pixelRatio, right - x, height - 2 * pixelRatio);