Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Unified Diff: tracing/tracing/base/quad.html

Issue 2390373003: Change all == to === and != to !== in trace viewer. (Closed)
Patch Set: more changes from code review Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tracing/tracing/base/math.html ('k') | tracing/tracing/base/range.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tracing/tracing/base/quad.html
diff --git a/tracing/tracing/base/quad.html b/tracing/tracing/base/quad.html
index 0a1b46958868fc819a958c66092be2456aa50b66..9e66c5e21c5ffbac7061752a2e9b9ab3453989ee 100644
--- a/tracing/tracing/base/quad.html
+++ b/tracing/tracing/base/quad.html
@@ -70,7 +70,7 @@ tr.exportTo('tr.b', function() {
}
Quad.from8Array = function(arr) {
- if (arr.length != 8)
+ if (arr.length !== 8)
throw new Error('Array must be 8 long');
var q = new Quad();
q.p1[0] = arr[0];
@@ -126,14 +126,14 @@ tr.exportTo('tr.b', function() {
// Simple rectangle check. Note: will not handle out-of-order components.
var bounds = this.boundingRect();
return (
- bounds.x == this.p1[0] &&
- bounds.y == this.p1[1] &&
- bounds.width == this.p2[0] - this.p1[0] &&
- bounds.y == this.p2[1] &&
- bounds.width == this.p3[0] - this.p1[0] &&
- bounds.height == this.p3[1] - this.p2[1] &&
- bounds.x == this.p4[0] &&
- bounds.height == this.p4[1] - this.p2[1]
+ bounds.x === this.p1[0] &&
+ bounds.y === this.p1[1] &&
+ bounds.width === this.p2[0] - this.p1[0] &&
+ bounds.y === this.p2[1] &&
+ bounds.width === this.p3[0] - this.p1[0] &&
+ bounds.height === this.p3[1] - this.p2[1] &&
+ bounds.x === this.p4[0] &&
+ bounds.height === this.p4[1] - this.p2[1]
);
},
@@ -215,7 +215,7 @@ tr.exportTo('tr.b', function() {
var b1 = sign(pt, p1, p2) < 0.0;
var b2 = sign(pt, p2, p3) < 0.0;
var b3 = sign(pt, p3, p1) < 0.0;
- return ((b1 == b2) && (b2 == b3));
+ return ((b1 === b2) && (b2 === b3));
}
function pointInImplicitQuad(point, p1, p2, p3, p4) {
« no previous file with comments | « tracing/tracing/base/math.html ('k') | tracing/tracing/base/range.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698