tracing/tracing/ui/base/chart_base.html - Issue 2390373003: Change all == to === and != to !== in trace viewer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tracing/tracing/ui/base/chart_base.html

Issue 2390373003: Change all == to === and != to !== in trace viewer. (Closed)

Patch Set: more changes from code review Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tracing/tracing/ui/base/chart_base.html

diff --git a/tracing/tracing/ui/base/chart_base.html b/tracing/tracing/ui/base/chart_base.html

index 1a5b943e480b69e18b17c0d9f1b0584ee7438529..e57daf3ac6c1d79da6f04c046cd0c062ab073376 100644

--- a/tracing/tracing/ui/base/chart_base.html

+++ b/tracing/tracing/ui/base/chart_base.html

@@ -454,7 +454,7 @@ tr.exportTo('tr.ui.b', function() {

popTempHighlightedLegendKey: function(key) {

- if (this.tempHighlightedLegendKey_ != key)

+ if (this.tempHighlightedLegendKey_ !== key)

throw new Error('pop cannot happen');

this.tempHighlightedLegendKey_ = undefined;

this.updateHighlight_();