tracing/tracing/extras/importer/gcloud_trace/gcloud_trace_importer.html - Issue 2390373003: Change all == to === and != to !== in trace viewer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tracing/tracing/extras/importer/gcloud_trace/gcloud_trace_importer.html

Issue 2390373003: Change all == to === and != to !== in trace viewer. (Closed)

Patch Set: more changes from code review Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tracing/tracing/extras/importer/gcloud_trace/gcloud_trace_importer.html

diff --git a/tracing/tracing/extras/importer/gcloud_trace/gcloud_trace_importer.html b/tracing/tracing/extras/importer/gcloud_trace/gcloud_trace_importer.html

index b110a7e6c82d4d8e3a42173c9e5eb2695aaaea9b..08bc702914e26498b5105b4eaae3a87617fcd0af 100644

--- a/tracing/tracing/extras/importer/gcloud_trace/gcloud_trace_importer.html

+++ b/tracing/tracing/extras/importer/gcloud_trace/gcloud_trace_importer.html

@@ -32,7 +32,7 @@ tr.exportTo('tr.e.importer.gcloud_trace', function() {

if (normalizedEventData.length < 14)

return false;

- return normalizedEventData.slice(0, 14) == '{"projectId":"';

+ return normalizedEventData.slice(0, 14) === '{"projectId":"';

};

GcloudTraceImporter.prototype = {

« no previous file with comments | « tracing/tracing/extras/importer/etw/thread_parser.html ('k') | tracing/tracing/extras/importer/gzip_importer.html » ('j') | no next file with comments »