Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Unified Diff: tracing/tracing/ui/extras/side_panel/time_summary_side_panel.html

Issue 2390373003: Change all == to === and != to !== in trace viewer. (Closed)
Patch Set: more changes from code review Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tracing/tracing/ui/extras/side_panel/time_summary_side_panel.html
diff --git a/tracing/tracing/ui/extras/side_panel/time_summary_side_panel.html b/tracing/tracing/ui/extras/side_panel/time_summary_side_panel.html
index 1542b13f88dd91bbdb41fb159565fe386af663d2..7391d050ced3f3a8a11e129360f09a1f73d3bbd4 100644
--- a/tracing/tracing/ui/extras/side_panel/time_summary_side_panel.html
+++ b/tracing/tracing/ui/extras/side_panel/time_summary_side_panel.html
@@ -83,7 +83,7 @@ found in the LICENSE file.
},
appendGroupContents: function(group) {
- if (group.model != this.model)
+ if (group.model !== this.model)
throw new Error('Models must be the same');
group.allSlices.forEach(function(slice) {
@@ -165,7 +165,7 @@ found in the LICENSE file.
trimPieChartData: function(groups, otherGroup, getValue, opt_extraValue) {
// Copy the array so it can be mutated.
groups = groups.filter(function(d) {
- return getValue(d) != 0;
+ return getValue(d) !== 0;
});
// Figure out total array range.
@@ -294,7 +294,7 @@ found in the LICENSE file.
updateShowCpuIdleTimeCheckboxVisibility_: function() {
if (!this.showCpuIdleTimeCheckbox_)
return;
- var visible = this.groupingUnit_ == CPU_TIME_GROUPING_UNIT;
+ var visible = this.groupingUnit_ === CPU_TIME_GROUPING_UNIT;
if (visible)
this.showCpuIdleTimeCheckbox_.style.display = '';
else
@@ -302,10 +302,10 @@ found in the LICENSE file.
},
getGroupNameForThread_: function(thread) {
- if (this.groupBy_ == GROUP_BY_THREAD_NAME)
+ if (this.groupBy_ === GROUP_BY_THREAD_NAME)
return thread.name ? thread.name : thread.userFriendlyName;
- if (this.groupBy_ == GROUP_BY_PROCESS_NAME)
+ if (this.groupBy_ === GROUP_BY_PROCESS_NAME)
return thread.parent.userFriendlyName;
},
@@ -339,7 +339,7 @@ found in the LICENSE file.
// Helper function for working with the produced group.
var getValueFromGroup = function(group) {
- if (this.groupingUnit_ == WALL_TIME_GROUPING_UNIT)
+ if (this.groupingUnit_ === WALL_TIME_GROUPING_UNIT)
return group.wallTime;
return group.cpuTime;
}.bind(this);
@@ -381,7 +381,7 @@ found in the LICENSE file.
getValueFromGroup,
extraValue);
- if (groups.length == 0) {
+ if (groups.length === 0) {
Polymer.dom(resultArea).appendChild(
tr.ui.b.createSpan({textContent: 'No data'}));
return undefined;

Powered by Google App Engine
This is Rietveld 408576698