Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Unified Diff: tracing/tracing/ui/base/list_view.html

Issue 2390373003: Change all == to === and != to !== in trace viewer. (Closed)
Patch Set: more changes from code review Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tracing/tracing/ui/base/list_view.html
diff --git a/tracing/tracing/ui/base/list_view.html b/tracing/tracing/ui/base/list_view.html
index f6b0a51076a95a662433616f921749eedd5586c0..c50c463775841b18ffb31af7b006e852dccc1a85 100644
--- a/tracing/tracing/ui/base/list_view.html
+++ b/tracing/tracing/ui/base/list_view.html
@@ -51,7 +51,7 @@ tr.exportTo('tr.ui.b', function() {
configurable: true,
set: function(value) {
var oldSelection = listView.selectedElement;
- if (oldSelection && oldSelection != this && value)
+ if (oldSelection && oldSelection !== this && value)
Polymer.dom(listView.selectedElement).removeAttribute(
'selected');
if (value)
@@ -59,7 +59,7 @@ tr.exportTo('tr.ui.b', function() {
else
Polymer.dom(this).removeAttribute('selected');
var newSelection = listView.selectedElement;
- if (newSelection != oldSelection)
+ if (newSelection !== oldSelection)
tr.b.dispatchSimpleEvent(listView, 'selection-changed', false);
},
get: function() {
@@ -99,7 +99,7 @@ tr.exportTo('tr.ui.b', function() {
return;
}
- if (el.parentElement != this)
+ if (el.parentElement !== this)
throw new Error(
'Can only select elements that are children of this list view');
el.selected = true;
@@ -122,7 +122,7 @@ tr.exportTo('tr.ui.b', function() {
if (currentSelectedElement)
Polymer.dom(currentSelectedElement).removeAttribute('selected');
var element = e.target;
- while (element.parentElement != this)
+ while (element.parentElement !== this)
element = element.parentElement;
if (element !== currentSelectedElement)
Polymer.dom(element).setAttribute('selected', 'selected');
@@ -133,7 +133,7 @@ tr.exportTo('tr.ui.b', function() {
if (this.selectedElement === undefined)
return;
- if (e.keyCode == 38) { // Up arrow.
+ if (e.keyCode === 38) { // Up arrow.
var prev = Polymer.dom(this.selectedElement).previousSibling;
if (prev) {
prev.selected = true;
@@ -141,7 +141,7 @@ tr.exportTo('tr.ui.b', function() {
e.preventDefault();
return true;
}
- } else if (e.keyCode == 40) { // Down arrow.
+ } else if (e.keyCode === 40) { // Down arrow.
var next = Polymer.dom(this.selectedElement).nextSibling;
if (next) {
next.selected = true;
« no previous file with comments | « tracing/tracing/ui/base/list_and_associated_view.html ('k') | tracing/tracing/ui/base/mouse_mode_selector.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698