Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Unified Diff: tracing/tracing/extras/importer/linux_perf/disk_parser.html

Issue 2390373003: Change all == to === and != to !== in trace viewer. (Closed)
Patch Set: more changes from code review Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tracing/tracing/extras/importer/linux_perf/disk_parser.html
diff --git a/tracing/tracing/extras/importer/linux_perf/disk_parser.html b/tracing/tracing/extras/importer/linux_perf/disk_parser.html
index 05084ebcb2f5908e2a5cc8798c58f2dc44926247..7e223467fc3ec68cd2dbd6fd1075b1577644feec 100644
--- a/tracing/tracing/extras/importer/linux_perf/disk_parser.html
+++ b/tracing/tracing/extras/importer/linux_perf/disk_parser.html
@@ -207,7 +207,7 @@ tr.exportTo('tr.e.importer.linux_perf', function() {
var device = event[1];
var inode = parseInt(event[2]);
- var datasync = event[4] == 1;
+ var datasync = (event[4] === '1') || (event[4] === 1);
var key = device + '-' + inode;
var action = datasync ? 'fdatasync' : 'fsync';
this.openAsyncSlice(ts, 'ext4', eventBase.threadName, eventBase.pid,
@@ -261,16 +261,16 @@ tr.exportTo('tr.e.importer.linux_perf', function() {
if (event[2]) {
action += ' flush';
}
- if (event[4] == 'F') {
+ if (event[4] === 'F') {
action += ' fua';
}
- if (event[5] == 'A') {
+ if (event[5] === 'A') {
action += ' ahead';
}
- if (event[6] == 'S') {
+ if (event[6] === 'S') {
action += ' sync';
}
- if (event[7] == 'M') {
+ if (event[7] === 'M') {
action += ' meta';
}
var device = event[1];
« no previous file with comments | « tracing/tracing/extras/importer/gzip_importer.html ('k') | tracing/tracing/extras/importer/linux_perf/exynos_parser_test.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698