tracing/tracing/extras/importer/etw/thread_parser.html - Issue 2390373003: Change all == to === and != to !== in trace viewer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tracing/tracing/extras/importer/etw/thread_parser.html

Issue 2390373003: Change all == to === and != to !== in trace viewer. (Closed)

Patch Set: more changes from code review Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tracing/tracing/extras/importer/etw/process_parser.html ('k') | tracing/tracing/extras/importer/gcloud_trace/gcloud_trace_importer.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tracing/tracing/extras/importer/etw/thread_parser.html

diff --git a/tracing/tracing/extras/importer/etw/thread_parser.html b/tracing/tracing/extras/importer/etw/thread_parser.html

index 4c39354627b3088a8af066aa2dd181b0ca0e6001..530cb69e5a9899bd6f8cca3ca75bab964b6282c0 100644

--- a/tracing/tracing/extras/importer/etw/thread_parser.html

+++ b/tracing/tracing/extras/importer/etw/thread_parser.html

@@ -82,10 +82,10 @@ tr.exportTo('tr.e.importer.etw', function() {

var threadFlags;

var waitMode;

- if (header.version == 1) {

+ if (header.version === 1) {

// On version 1, only start events have extended information.

- if (header.opcode == kThreadStartOpcode ||

- header.opcode == kThreadDCStartOpcode) {

+ if (header.opcode === kThreadStartOpcode ||

+ header.opcode === kThreadDCStartOpcode) {

stackBase = decoder.decodeUInteger(header.is64);

stackLimit = decoder.decodeUInteger(header.is64);

userStackBase = decoder.decodeUInteger(header.is64);

@@ -102,7 +102,7 @@ tr.exportTo('tr.e.importer.etw', function() {

userStackLimit = decoder.decodeUInteger(header.is64);

// Version 2 produces a field named 'startAddr'.

- if (header.version == 2)

+ if (header.version === 2)

startAddr = decoder.decodeUInteger(header.is64);

else

affinity = decoder.decodeUInteger(header.is64);

@@ -111,7 +111,7 @@ tr.exportTo('tr.e.importer.etw', function() {

tebBase = decoder.decodeUInteger(header.is64);

subProcessTag = decoder.decodeUInt32();

- if (header.version == 3) {

+ if (header.version === 3) {

basePriority = decoder.decodeUInt8();

pagePriority = decoder.decodeUInt8();

ioPriority = decoder.decodeUInt8();

@@ -140,7 +140,7 @@ tr.exportTo('tr.e.importer.etw', function() {

decodeCSwitchFields: function(header, decoder) {

- if (header.version != 2)

+ if (header.version !== 2)

throw new Error('Incompatible Thread event version.');

// Decode CSwitch payload.