Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Unified Diff: tracing/tracing/ui/extras/chrome/cc/layer_tree_quad_stack_view.html

Issue 2390373003: Change all == to === and != to !== in trace viewer. (Closed)
Patch Set: more changes from code review Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tracing/tracing/ui/extras/chrome/cc/layer_tree_quad_stack_view.html
diff --git a/tracing/tracing/ui/extras/chrome/cc/layer_tree_quad_stack_view.html b/tracing/tracing/ui/extras/chrome/cc/layer_tree_quad_stack_view.html
index 81f9f5e575eb28b197d6aa4743df56f1a66e5408..100741e8bb116326134a3286dc28c6567f3b405a 100644
--- a/tracing/tracing/ui/extras/chrome/cc/layer_tree_quad_stack_view.html
+++ b/tracing/tracing/ui/extras/chrome/cc/layer_tree_quad_stack_view.html
@@ -382,7 +382,7 @@ tr.exportTo('tr.ui.e.chrome.cc', function() {
var selectableQuads = e.quads.filter(function(q) {
return q.selectionToSetIfClicked !== undefined;
});
- if (selectableQuads.length == 0) {
+ if (selectableQuads.length === 0) {
this.selection = undefined;
return;
}
@@ -390,7 +390,7 @@ tr.exportTo('tr.ui.e.chrome.cc', function() {
// Sort the quads low to high on stackingGroupId.
selectableQuads.sort(function(x, y) {
var z = x.stackingGroupId - y.stackingGroupId;
- if (z != 0)
+ if (z !== 0)
return z;
return x.selectionToSetIfClicked.specicifity -
y.selectionToSetIfClicked.specicifity;
@@ -865,11 +865,11 @@ tr.exportTo('tr.ui.e.chrome.cc', function() {
},
getValueForHeatmap_: function(tile, heatmapType) {
- if (heatmapType == TILE_HEATMAP_TYPE.SCHEDULED_PRIORITY) {
- return tile.scheduledPriority == 0 ?
+ if (heatmapType === TILE_HEATMAP_TYPE.SCHEDULED_PRIORITY) {
+ return tile.scheduledPriority === 0 ?
undefined :
tile.scheduledPriority;
- } else if (heatmapType == TILE_HEATMAP_TYPE.USING_GPU_MEMORY) {
+ } else if (heatmapType === TILE_HEATMAP_TYPE.USING_GPU_MEMORY) {
if (tile.isSolidColor)
return 0.5;
return tile.isUsingGpuMemory ? 0 : 1;
@@ -878,7 +878,7 @@ tr.exportTo('tr.ui.e.chrome.cc', function() {
getMinMaxForHeatmap_: function(tiles, heatmapType) {
var range = new tr.b.Range();
- if (heatmapType == TILE_HEATMAP_TYPE.USING_GPU_MEMORY) {
+ if (heatmapType === TILE_HEATMAP_TYPE.USING_GPU_MEMORY) {
range.addValue(0);
range.addValue(1);
return range;
@@ -933,7 +933,7 @@ tr.exportTo('tr.ui.e.chrome.cc', function() {
// TODO(vmpstr): Make the stiching of tiles and layers a part of
// tile construction (issue 346)
- if (layer.layerId != tile.layerId)
+ if (layer.layerId !== tile.layerId)
continue;
tiles.push(tile);
@@ -1037,7 +1037,7 @@ tr.exportTo('tr.ui.e.chrome.cc', function() {
// Generate quads back-to-front.
var layer = layers[layers.length - i];
alreadyVisitedLayerIds[layer.layerId] = true;
- if (layer.objectInstance.name == 'cc::NinePatchLayerImpl')
+ if (layer.objectInstance.name === 'cc::NinePatchLayerImpl')
continue;
var layerQuad = layer.layerQuad.clone();
@@ -1051,7 +1051,7 @@ tr.exportTo('tr.ui.e.chrome.cc', function() {
layerQuad.stackingGroupId = nextStackingGroupId++;
layerQuad.selectionToSetIfClicked = new cc.LayerSelection(layer);
layerQuad.layer = layer;
- if (this.showOtherLayers && this.selectedLayer == layer)
+ if (this.showOtherLayers && this.selectedLayer === layer)
layerQuad.upperBorderColor = 'rgb(156,189,45)';
if (this.showAnimationBounds)
@@ -1095,7 +1095,7 @@ tr.exportTo('tr.ui.e.chrome.cc', function() {
}
this.layerTreeImpl.iterLayers(function(layer, depth, isMask, isReplica) {
- if (!this.showOtherLayers && this.selectedLayer != layer)
+ if (!this.showOtherLayers && this.selectedLayer !== layer)
return;
if (alreadyVisitedLayerIds[layer.layerId])
return;
@@ -1167,7 +1167,7 @@ tr.exportTo('tr.ui.e.chrome.cc', function() {
if (tile === undefined)
continue;
- if (tile.containingSnapshot == lthi)
+ if (tile.containingSnapshot === lthi)
tasks.push(event);
}
return tasks;

Powered by Google App Engine
This is Rietveld 408576698