tracing/tracing/ui/extras/about_tracing/record_selection_dialog.html - Issue 2390373003: Change all == to === and != to !== in trace viewer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tracing/tracing/ui/extras/about_tracing/record_selection_dialog.html

Issue 2390373003: Change all == to === and != to !== in trace viewer. (Closed)

Patch Set: more changes from code review Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tracing/tracing/ui/extras/about_tracing/record_controller.html ('k') | tracing/tracing/ui/extras/about_tracing/xhr_based_tracing_controller_client.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tracing/tracing/ui/extras/about_tracing/record_selection_dialog.html

diff --git a/tracing/tracing/ui/extras/about_tracing/record_selection_dialog.html b/tracing/tracing/ui/extras/about_tracing/record_selection_dialog.html

index d84ac56541f2ea04f94867a23246cb3b3888dab4..71a333bf60d544c8574693d32654983a615da180 100644

--- a/tracing/tracing/ui/extras/about_tracing/record_selection_dialog.html

+++ b/tracing/tracing/ui/extras/about_tracing/record_selection_dialog.html

@@ -457,7 +457,7 @@ tr.exportTo('tr.ui.e.about_tracing', function() {

var categories = [];

var allCategories = this.allCategories_();

for (var category in allCategories) {

- var disabled = category.indexOf('disabled-by-default-') == 0;

+ var disabled = category.indexOf('disabled-by-default-') === 0;

if (this.currentlyChosenPreset_.indexOf(category) >= 0) {

if (disabled)

categories.push(category);

@@ -587,7 +587,7 @@ tr.exportTo('tr.ui.e.about_tracing', function() {

var categories = [];

var disabledCategories = [];

for (var category in allCategories) {

- if (category.indexOf('disabled-by-default-') == 0)

+ if (category.indexOf('disabled-by-default-') === 0)

disabledCategories.push(category);

else

categories.push(category);

@@ -595,7 +595,7 @@ tr.exportTo('tr.ui.e.about_tracing', function() {

disabledCategories = disabledCategories.sort(ignoreCaseCompare);

categories = categories.sort(ignoreCaseCompare);

- if (this.categories_.length == 0) {

+ if (this.categories_.length === 0) {

this.infoBarGroup_.addMessage(

'No categories found; recording will use default categories.');

}