Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Unified Diff: tracing/tracing/extras/importer/ddms_importer.html

Issue 2390373003: Change all == to === and != to !== in trace viewer. (Closed)
Patch Set: more changes from code review Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tracing/tracing/extras/importer/ddms_importer.html
diff --git a/tracing/tracing/extras/importer/ddms_importer.html b/tracing/tracing/extras/importer/ddms_importer.html
index 0874323d11d6040ab7c7c4136397260c54ed6e25..a4019cefcd152381a0810dd0d1bdb8b4f03e1a73 100644
--- a/tracing/tracing/extras/importer/ddms_importer.html
+++ b/tracing/tracing/extras/importer/ddms_importer.html
@@ -133,11 +133,11 @@ tr.exportTo('tr.e.importer.ddms', function() {
var traceReader = new Reader(this.data_.slice(divider));
var magic = traceReader.uint32();
- if (magic != kTraceMagicValue) {
+ if (magic !== kTraceMagicValue) {
throw Error('Failed to match magic value');
}
this.version_ = traceReader.uint16();
- if (this.version_ != kTraceVersionDualClock) {
+ if (this.version_ !== kTraceVersionDualClock) {
throw Error('Unknown version');
}
var dataOffest = traceReader.uint16();
@@ -160,7 +160,7 @@ tr.exportTo('tr.e.importer.ddms', function() {
var action = methodPacked & kTraceMethodActionMask;
var thread = this.getTid(tid);
method = this.getMethodName(method);
- if (action == kTraceMethodEnter) {
+ if (action === kTraceMethodEnter) {
thread.sliceGroup.beginSlice(kCategory, method, wallClockSinceStart,
undefined, cpuSinceStart);
} else if (thread.sliceGroup.openSliceCount) {
« no previous file with comments | « tracing/tracing/extras/importer/android/event_log_importer.html ('k') | tracing/tracing/extras/importer/etw/etw_importer.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698