Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Unified Diff: tracing/tracing/ui/analysis/generic_object_view.html

Issue 2390373003: Change all == to === and != to !== in trace viewer. (Closed)
Patch Set: more changes from code review Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tracing/tracing/ui/analysis/generic_object_view.html
diff --git a/tracing/tracing/ui/analysis/generic_object_view.html b/tracing/tracing/ui/analysis/generic_object_view.html
index e6f4a8355b3b9ebb89ddfd23b4873e95e20dd707..14797a9aa387f0b543fd545a22b87f1de12c647d 100644
--- a/tracing/tracing/ui/analysis/generic_object_view.html
+++ b/tracing/tracing/ui/analysis/generic_object_view.html
@@ -44,7 +44,7 @@ function isTable(object) {
for (var colName in object[i]) {
if (i && (object[0][colName] === undefined)) return false;
var cellType = typeof object[i][colName];
- if (cellType !== 'string' && cellType != 'number') return false;
+ if (cellType !== 'string' && cellType !== 'number') return false;
}
if (i) {
for (var colName in object[0]) {
@@ -96,10 +96,10 @@ Polymer({
if (!(object instanceof Object)) {
var type = typeof object;
- if (type == 'string') {
+ if (type === 'string') {
var objectReplaced = false;
- if ((object[0] == '{' && object[object.length - 1] == '}') ||
- (object[0] == '[' && object[object.length - 1] == ']')) {
+ if ((object[0] === '{' && object[object.length - 1] === '}') ||
+ (object[0] === '[' && object[object.length - 1] === ']')) {
try {
object = JSON.parse(object);
objectReplaced = true;
@@ -111,7 +111,7 @@ Polymer({
var lines = object.split('\n');
lines.forEach(function(line, i) {
var text, ioff, ll, ss;
- if (i == 0) {
+ if (i === 0) {
text = '"' + line;
ioff = 0;
ll = label;
@@ -192,7 +192,7 @@ Polymer({
appendElementsForArray_: function(
label, object, indent, depth, maxDepth, suffix) {
- if (object.length == 0) {
+ if (object.length === 0) {
this.appendSimpleText_(label, indent, '[]', suffix);
return;
}
@@ -255,7 +255,7 @@ Polymer({
appendElementsForObject_: function(
label, object, indent, depth, maxDepth, suffix) {
var keys = tr.b.dictionaryKeys(object);
- if (keys.length == 0) {
+ if (keys.length === 0) {
this.appendSimpleText_(label, indent, '{}', suffix);
return;
}
« no previous file with comments | « tracing/tracing/ui/analysis/analysis_view.html ('k') | tracing/tracing/ui/analysis/multi_event_summary.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698